Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cmd/gaia #4104

Closed
4 tasks
alessio opened this issue Apr 12, 2019 · 1 comment · Fixed by #4347
Closed
4 tasks

Remove cmd/gaia #4104

alessio opened this issue Apr 12, 2019 · 1 comment · Fixed by #4347
Assignees
@alessio

Comments

@alessio
Copy link
Contributor

alessio commented Apr 12, 2019 •
edited
Loading

As An SDK Developer
I Want to remove the gaia directory from the SDK repository
So That I can maintain gaia in a separate repository.

AC1

Given I am in the root directory of the sdk repository
When I run make
Then the binaries gaiacli gaiad gaiadebug gaiakeyutil gaiareplay are NOT installed in $GOPATH/bin

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@rigelrozanski
Copy link
Contributor

Based on many slack conversations - we're not going to remove gaia but rather rename it for the time being until we can migrate out the CLI tests at which point we will remove gaiad and gaiacli but still keep the "app" for simulation testing

@alessio alessio mentioned this issue May 16, 2019
Merged
5 tasks
@alessio alessio self-assigned this May 16, 2019
alessio added a commit that referenced this issue May 18, 2019
@alessio
Gaia is removed from cosmos-sdk repository.
af8de93 
Few changes were required to make sure no packages depend on gaia subpackages.

CI config is amended accordingly.

Unnecessary targets are removed from Makefile.

Simulations run through a lightweight version of gaia renamed to simapp.

Closes: #4104
@alessio alessio mentioned this issue May 18, 2019
Closed
5 tasks
alessio pushed a commit that referenced this issue May 18, 2019
Remove gaia (#4347)
71d71f2 
Gaia is removed from cosmos-sdk repository.

Few changes were required to make sure no packages depend on gaia subpackages.

CI config is amended accordingly.

Unnecessary targets are removed from Makefile.

Simulations run through a lightweight version of gaia renamed to simapp.

Closes: #4104
@fedekunze fedekunze mentioned this issue Jul 19, 2019
Closed
4 tasks
krunkosaurus added a commit to krunkosaurus/gaia that referenced this issue Mar 1, 2020
@krunkosaurus
Update documentation gaiad.toml > app.toml
1551477 
Update documentation referencing gaiad.toml to app.toml per cosmos/cosmos-sdk#4104
@krunkosaurus krunkosaurus mentioned this issue Mar 1, 2020
Merged
11 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this issue May 22, 2023
Remove gaia (cosmos#4347)
18b3928 
Gaia is removed from cosmos-sdk repository.

Few changes were required to make sure no packages depend on gaia subpackages.

CI config is amended accordingly.

Unnecessary targets are removed from Makefile.

Simulations run through a lightweight version of gaia renamed to simapp.

Closes: cosmos#4104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove gaia cosmos/cosmos-sdk
Gaia is removed from cosmos-sdk repository. cosmos/cosmos-sdk
2 participants
@alessio @rigelrozanski