Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor x/auth cli tests and add docs #8711

Closed
7 tasks
sahith-narahari opened this issue Feb 26, 2021 · 6 comments · Fixed by #8718
Closed
7 tasks

Refactor x/auth cli tests and add docs #8711

sahith-narahari opened this issue Feb 26, 2021 · 6 comments · Fixed by #8718
Assignees
@sahith-narahari
Labels
T:Docs Changes and features related to documentation. Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@sahith-narahari
Copy link
Contributor

Summary

This is a list of improvements that can be worked on to cleanup x/auth module

  • Refactor cli tx commands
  • Refactor cli_tests which has lot of common code currently
  • Document multisign, multisign batch and sign batch

cc\ @alessio @robert-zaremba @barriebyron

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@sahith-narahari sahith-narahari added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. T:Docs Changes and features related to documentation. labels Feb 26, 2021
@sahith-narahari sahith-narahari mentioned this issue Feb 26, 2021
Merged
9 tasks
@sahith-narahari
Copy link
Contributor Author

The docs currently highlight on creating a tx and signing a tx, would be nice to extend them to demonstrate multisign features and sign batch

@barriebyron barriebyron mentioned this issue Feb 26, 2021
Merged
6 tasks
@sahith-narahari
Copy link
Contributor Author

reopening this as only part of it was addressed in #8718

@amaury1093 amaury1093 mentioned this issue Mar 1, 2021
Merged
9 tasks
@clevinson
Copy link
Contributor

Is this planning to address also some of the larger refactors discussed in #8528 ?

@sahith-narahari sahith-narahari self-assigned this Mar 26, 2021
@sahith-narahari
Copy link
Contributor Author

Is this planning to address also some of the larger refactors discussed in #8528 ?

This is a minor refactor of tests, and doesn't include changes proposed in #8528

@robert-zaremba
Copy link
Collaborator

This is related to: #7318 meta-issue
I will add link it there as a subtask.

@robert-zaremba
Copy link
Collaborator

@sahith-narahari - could you update the title to more specific one, please?

@robert-zaremba robert-zaremba mentioned this issue Mar 26, 2021
Closed
9 tasks
@sahith-narahari sahith-narahari changed the title x/auth code cleanup and docs Refactor x/auth cli tests and add docs Mar 26, 2021
@sahith-narahari sahith-narahari mentioned this issue Apr 6, 2021
Merged
9 tasks
@github-actions github-actions bot added the stale label Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sahith-narahari sahith-narahari

Labels
T:Docs Changes and features related to documentation. Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
4 participants
@aaronc @robert-zaremba @clevinson @sahith-narahari