fix: per 8711 fix typo and minor command text edit for multi sign batch command #8718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 26, 2021 09:20
…oper documentation style guide advice here "one or more" https://developers.google.com/style/plurals-parentheses
… standards, and move only for clarity
…ported since the unsupported list is incomplete by definition
…the active voice and specify who or what performed the action
barriebyron
requested review from
aaronc,
alessio and
alexanderbez
as code owners
alessio
approved these changes
Feb 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #8718 +/- ##
=======================================
Coverage 61.35% 61.35%
=======================================
Files 671 671
Lines 38322 38322
=======================================
+ Hits 23512 23514 +2
+ Misses 12351 12350 -1
+ Partials 2459 2458 -1
|
tac0turtle
approved these changes
Feb 27, 2021
mergify bot
pushed a commit
that referenced
this pull request
Feb 27, 2021
…ch command (#8718) Co-authored-by: Alessio Treglia <[email protected]> (cherry picked from commit 68e7a3a)
alessio
pushed a commit
that referenced
this pull request
Feb 27, 2021
…ch command (#8718) (#8721) Co-authored-by: Alessio Treglia <[email protected]> (cherry picked from commit 68e7a3a) Co-authored-by: Barrie Byron <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed a typo in the output of x/auth/client/cli/tx_multisign.go and did minor edits while I was in there.
Let me know if this type of edit is helpful.
part of but does not close: #8711
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes