Injection of Signing algorithm in Keys Add CLI command.

[jgimeno]

Summary

When a user creates a new SigningAlgo in order to be used by the keyring the only way they can append it as an option is to rewrite the Add command. We can try to find a way that a custom signing algorithm can be injected in the keyring without having to rewrite the command.

• add a new command to list supported algos (eg: simapp keys list-algos) Add a new command to list supported algos #8886
• Design signing injection

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[araskachoi]

we are particularly interested in this use case where we would like to pass our own custom "eth_secp256k1" signing algorithm to pass into account generation. However, when we use the sdk keys add cmd, we are unable to pass our own algorithm and it automatically defaults to secp256k1 signing algorithm that is native to cosmos-sdk. If there could be a way we can pass these as arguments and dynamically generate the keyring with the passed signing algorithm(s)?

thanks in advance for your help!

[amaury1093]

Is this related/duplicate of #6500?

[alessio]

Is this related/duplicate of #6500?

Yes, I believe it is related

[robert-zaremba]

In #8862 I'm extending the hd algos with:

• generalizing ECDSA derivation
• with above - adding support to sepc256r1 to keyring. Would be good if some folks with good knowledge of hardware wallets can chime in that PR.

[robert-zaremba]

I added subtasks to just start tackling this issue.

[alessio]

@robert-zaremba #8862 is not necessarily related to this. It does not look like a sub-task to me because this issue is not about supporting more algos in the SDK. This issue is about allowing applications to use their own algos and inject them in the keyring so that they could be supported by the keyring and the cli commands.

[clevinson]

Re-opening this as it's not actually taken care of by #8886, and we should still be tracking the injection of new signing algos.

[JulianToledano]

hey guys!
As far as I understand, the keyring allows you to configure your algos through options, as seen here:

cosmos-sdk/crypto/keyring/keyring.go

Lines 224 to 226 in 2e9e5d6

	for _, optionFn := range opts {
	optionFn(&options)
	}

Then, applications can set these options through their context:

cosmos-sdk/client/context.go

Lines 72 to 76 in 2e9e5d6

	// WithKeyringOptions returns a copy of the context with an updated keyring.
	func (ctx Context) WithKeyringOptions(opts ...keyring.Option) Context {
	ctx.KeyringOptions = opts
	return ctx
	}

cosmos-sdk/client/context.go

Lines 404 to 411 in 2e9e5d6

	// NewKeyringFromBackend gets a Keyring object from a backend
	func NewKeyringFromBackend(ctx Context, backend string) (keyring.Keyring, error) {
	if ctx.Simulate {
	backend = keyring.BackendMemory
	}
	return keyring.New(sdk.KeyringServiceName(), backend, ctx.KeyringDir, ctx.Input, ctx.Codec, ctx.KeyringOptions...)
	}

With this approach, it doesn't seem necessary to rewrite the add command.

what do you guys think? It is sufficient to close this?
@tac0turtle @clevinson @alessio

[JulianToledano]

Closing this for now, as the context allows applications to pass their algorithms as an option. Feel free to reopen it if you believe this doesn't resolve the issue.