-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document how to create a new key type and add it to the keyring #6500
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
docs/basics/accounts.md has to be updated too, I think the Keybase api changed a little since then. |
Reading this again, I'm actually not 100% sure what's in scope:
@fedekunze Are you referring to:
|
@fedekunze Would you (or @alessio) be willing to write documentation on this piece? I think I am lacking context on how to achieve this. |
Hello folks, What is the state of this issue? I want to help. |
Summary
Problem Definition
Currently, the process of adding a new key type (eg: The Eth's secp256k1 used on Ethermint) to the keyring in not fully documented/tested, and it would be extremely helpful to add a dev guide.
Proposal
notSupportedAlgo
) that uses the same defaulthd.Secp256k1
type. This will prevent issues like client/keys: --algo flag silently falls back to default if user supplied algo is not supported #6402 from happening again.cc: @alessio @jgimeno
For Admin Use
The text was updated successfully, but these errors were encountered: