-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove legacy REST (backport #9594) #10037
Conversation
<!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description ref: #7517 * [x] Remove the x/{module}/client/rest folder * [x] Remove all glue code between simapp/modules and the REST server <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - see #9615 - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [x] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [x] reviewed API design and naming - [ ] reviewed documentation is accurate - see #9615 - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit cd22168) # Conflicts: # CHANGELOG.md # client/tx/tx.go # codec/amino_codec_test.go # x/auth/client/cli/query.go # x/auth/client/rest/broadcast.go # x/auth/client/rest/decode.go # x/auth/client/rest/encode.go # x/auth/client/rest/rest_test.go # x/authz/client/testutil/grpc.go # x/bank/client/rest/query_test.go # x/bank/client/rest/tx_test.go # x/gov/client/testutil/grpc.go # x/mint/client/testutil/grpc.go # x/params/client/testutil/grpc.go # x/slashing/client/testutil/grpc.go # x/staking/client/testutil/grpc.go
Visit https://dashboard.github.orijtech.com?back=0&pr=10037&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
can this be punted to 0.45 since this was meant for that release cycle? |
@marbar3778 This is required for #10034. We could choose to reduce the scope of this backport to only remove legacy broadcast & encode REST endpoints, as those are the endpoints that must be removed in order for #10034 to be merged safely. Do you think we'd be better off just back porting the removal of broadcast & encode? It was my thought that we might as well remove all, rather than only dropping some, but I could be convinced otherwise. |
This is an automatic backport of pull request #9594 done by Mergify.
Cherry-pick of cd22168 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/