Baseapp: Adding more tests #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1075 +/- ##
==========================================
+ Coverage 60.43% 60.63% +0.2%
==========================================
Files 89 89
Lines 4357 4357
==========================================
+ Hits 2633 2642 +9
+ Misses 1555 1548 -7
+ Partials 169 167 -2 |
ValarDragon
changed the title
ValarDragon
force-pushed
the
dev/baseapp_tests
branch
from
48eff65
to
cc0bda5
Compare
ValarDragon
changed the title
cwgoes
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some more tests to baseapp, per #556. This PR includes tests for CheckTx, and it checks that runTx works as expected given certain types of invalid messages.