docs: ADR-40 Migration spec #10891
Merged
docs: ADR-40 Migration spec #10891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
T: ADR
robert-zaremba
added
the
S:needs architecture review
adu-web3
reviewed
Jan 11, 2022
| }) | ||
| ``` | ||
|
|
||
| The `Migrate` function will read all entries from the save them to the AD-40 combined KV store. Cash layer should not be used and the operation must finish with a single Commit call. |
There was a problem hiding this comment.
thanks for catching, I cut the word... should be from store v1 DB
i-norden
approved these changes
Jan 12, 2022
i-norden
reviewed
Jan 12, 2022
4 tasks
19 tasks
Co-authored-by: Ian Norden <[email protected]>
aaronc
reviewed
Jan 19, 2022
There was a problem hiding this comment.
Makes sense. Thanks @robert-zaremba ! Glad there will be a smooth upgrade path
aaronc
approved these changes
Jan 19, 2022
robert-zaremba
added
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Iterative update to the ADR-40
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change