-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move server.GenerateCoinKey and server.GenerateSaveCoinKey to testutil #10956
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| package testutil | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/cosmos/cosmos-sdk/crypto/keyring" | ||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| ) | ||
|
|
||
| // GenerateCoinKey generates a new key mnemonic along with its addrress. | ||
| func GenerateCoinKey(algo keyring.SignatureAlgo) (sdk.AccAddress, string, error) { | ||
| // generate a private key, with mnemonic | ||
| info, secret, err := keyring.NewInMemory().NewMnemonic( | ||
| "name", | ||
| keyring.English, | ||
| sdk.GetConfig().GetFullBIP44Path(), | ||
| keyring.DefaultBIP39Passphrase, | ||
| algo, | ||
| ) | ||
| if err != nil { | ||
| return sdk.AccAddress{}, "", err | ||
| } | ||
|
|
||
| return sdk.AccAddress(info.GetPubKey().Address()), secret, nil | ||
| } | ||
|
|
||
| // GenerateSaveCoinKey generates a new key mnemonic with its addrress. | ||
| // If mnemonic is provided then it's used for key generation. | ||
| // The key is saved in the keyring. The function returns error if overwrite=true and the key | ||
| // already exists. | ||
| func GenerateSaveCoinKey( | ||
| keybase keyring.Keyring, | ||
| keyName, mnemonic string, | ||
| overwrite bool, | ||
| algo keyring.SignatureAlgo, | ||
| ) (sdk.AccAddress, string, error) { | ||
| exists := false | ||
| _, err := keybase.Key(keyName) | ||
| if err == nil { | ||
| exists = true | ||
| } | ||
|
|
||
| // ensure no overwrite | ||
| if !overwrite && exists { | ||
| return sdk.AccAddress{}, "", fmt.Errorf("key already exists, overwrite is disabled") | ||
| } | ||
|
|
||
| if exists { | ||
| if err := keybase.Delete(keyName); err != nil { | ||
| return sdk.AccAddress{}, "", fmt.Errorf("failed to overwrite key") | ||
| } | ||
| } | ||
|
|
||
| var ( | ||
| info keyring.Info | ||
| secret string | ||
| ) | ||
|
|
||
| if mnemonic != "" { | ||
| secret = mnemonic | ||
| info, err = keybase.NewAccount( | ||
| keyName, | ||
| mnemonic, | ||
| keyring.DefaultBIP39Passphrase, | ||
| sdk.GetConfig().GetFullBIP44Path(), | ||
| algo, | ||
| ) | ||
| } else { | ||
| info, secret, err = keybase.NewMnemonic( | ||
| keyName, | ||
| keyring.English, | ||
| sdk.GetConfig().GetFullBIP44Path(), | ||
| keyring.DefaultBIP39Passphrase, | ||
| algo, | ||
| ) | ||
| } | ||
| if err != nil { | ||
| return sdk.AccAddress{}, "", err | ||
| } | ||
|
|
||
| return sdk.AccAddress(info.GetAddress()), secret, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we decided to rollback the api breaking, deprecate this function and move it with the mnemonic feature to testutil package.