Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove hardcoded pubkey from tx simulation (backport #11282) #11288

Merged
merged 5 commits into from
Mar 10, 2022

Commits on Feb 28, 2022

  1. fix: remove hardcoded pubkey from tx simulation (#11282)

    ## Description
    
    Closes: #11283
    
    ---
    
    ### Author Checklist
    
    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*
    
    I have...
    
    - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] added `!` to the type prefix if API or client breaking change
    - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
    - [x] provided a link to the relevant issue or specification
    - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
    - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
    - [x] added a changelog entry to `CHANGELOG.md`
    - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [ ] updated the relevant documentation or specification
    - [ ] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed
    
    ### Reviewers Checklist
    
    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*
    
    I have...
    
    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)
    
    (cherry picked from commit e657190)
    
    # Conflicts:
    #	client/tx/factory.go
    #	client/tx/tx_test.go
    fedekunze authored and mergify-bot committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    ffbae86 View commit details
    Browse the repository at this point in the history
  2. fix conflicts

    fedekunze committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    ea9bacc View commit details
    Browse the repository at this point in the history
  3. fix

    fedekunze committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    637accd View commit details
    Browse the repository at this point in the history
  4. fix build

    fedekunze committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    61469a0 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. fix tests

    fedekunze committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    cfd3c74 View commit details
    Browse the repository at this point in the history