fix: ensure TxFactory has acc & seq fields when simulating tx in generate-only mode #11313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On regen ledger when using the CLI I noticed that
--gas auto
does not work in--generate-only
mode. I was able to reproduce it on Cosmos-SDKmaster
withbank send
msg's as well:Failed with the error:
After digging around on the SDK, I found that when broadcasting a tx we often call
txf.Prepare()
on the TxFactory to add acc number & sequence in case it isn't already set explicitly via CLI flags. However, we don't do this when callingtxf.PrintUnsignedTx()
. Usually this isn't a problem, but acc numbers & sequences are actually required when simulating a tx for calculating gas (e.g. if--gas auto
is set).This PR fixes the above issue by running
txf.Prepare()
prior to simulating the transaction for gas calculation in--generate-only
mode.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change