docs: ADR-052 State Commitment Listening #11371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
T: ADR
i-norden
force-pushed
the
adr_052
branch
3 times, most recently
from
82dea3f
to
3fba586
Compare
Comment on lines
+22
to
+25
| The SDK stores values in state storage in a protobuf encoded format. Each module defines their own custom types in | ||
| .proto definitions and these types are registered with a ProtoCodec that manages the marshalling and unmarshalling of these | ||
| types to and from the binary format that is persisted to disk. As such, an indefinite/unbounded number of protobuf types | ||
| need to be supported within the Cosmos ecosystem at large. |
There was a problem hiding this comment.
Is this true? Modules get access to an e.g. KVStore API which deals in raw []byte, is there something which enforces that those []byte are protobufs? Or maybe you're referring to something else?
19 tasks
7 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@i-norden any chance you can update the pr? |
|
closing this due to inactivity. @i-norden when you're ready please reopen or open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO: add more implementation details.
This is on-top of the ADR-051 branch, will change that before converting from draft status.
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change