feat: implement multi-send transaction command #11738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
julienrbrt
changed the title
julienrbrt
commented
Apr 24, 2022
| // {4A} / {8A} = {0A} | ||
| // {2A} / 0 = panics | ||
| // Note, if IsValid was true on Coins, IsValid stays true, | ||
| // unless the `divisor` is greater than the smallest coin amount. |
There was a problem hiding this comment.
I am uncertain if we actually want this behavior, but I created these helpers function for avoiding having to do for every coin:
sendCoins := coins
if split && !coins.IsZero() {
sendCoins[0].Amount = coins[0].Amount.Quo(totalAddr)
}If you find this better, then I can modify it and remove the changes in coins.
alexanderbez
approved these changes
Apr 25, 2022
Thanks for all the feedback :) Yes, that's why we need to multiply from |
julienrbrt
force-pushed
the
julien/7809-gaiad-tx-bank-multi-send-cli
branch
from
26e5d22
to
51ed808
Compare
julienrbrt
changed the title
alexanderbez
suggested changes
Apr 26, 2022
There was a problem hiding this comment.
@julienrbrt I completely forgot. We need to add a test to x/bank/client/testutil 👍
julienrbrt
changed the title
likhita-809
reviewed
Apr 27, 2022
alexanderbez
approved these changes
Apr 27, 2022
alexanderbez
approved these changes
Apr 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #11738 +/- ##
==========================================
+ Coverage 65.94% 66.02% +0.07%
==========================================
Files 669 669
Lines 70427 70599 +172
==========================================
+ Hits 46444 46613 +169
- Misses 21312 21316 +4
+ Partials 2671 2670 -1
|
|
@Mergifyio backport release/v0.46.x |
mergify bot
pushed a commit
that referenced
this pull request
Apr 29, 2022
Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Anil Kumar Kammari <[email protected]> (cherry picked from commit 6a9b824) # Conflicts: # x/bank/client/cli/tx.go
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #7809
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change