Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade module panic #11969

Merged
merged 3 commits into from
May 17, 2022
Merged

fix: upgrade module panic #11969

merged 3 commits into from
May 17, 2022

Conversation

alexanderbez
Copy link
Contributor

Description

Closes: #11957


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez requested a review from a team as a code owner May 16, 2022 13:14
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label May 16, 2022
@alexanderbez alexanderbez merged commit 450cd7f into main May 17, 2022
@alexanderbez alexanderbez deleted the bez/11957-fix-upgrade-panic branch May 17, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/upgrade
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

x/upgrade segmentation violation crash
5 participants