Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decouple x/staking from simapp #12343

Closed
wants to merge 2 commits into from

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jun 23, 2022

Closes: #12036


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt changed the title feat: decouple x/staking from simapp feat: decouple x/staking from simapp Jun 23, 2022
@julienrbrt julienrbrt force-pushed the julien/decouple-staking-simapp branch from d2baf83 to 8e2e8a5 Compare June 24, 2022 17:01
@julienrbrt julienrbrt force-pushed the julien/decouple-staking-simapp branch from eca13ec to d4b4aac Compare June 27, 2022 15:07
@github-actions github-actions bot added the C:CLI label Jun 28, 2022
@julienrbrt julienrbrt marked this pull request as ready for review June 28, 2022 15:38
@julienrbrt julienrbrt requested a review from a team as a code owner June 28, 2022 15:38
@julienrbrt julienrbrt force-pushed the julien/decouple-staking-simapp branch from 928cc38 to 26b3136 Compare June 29, 2022 00:02
@julienrbrt julienrbrt changed the base branch from main to epic/app-wiring June 29, 2022 13:40
@julienrbrt julienrbrt changed the base branch from epic/app-wiring to main June 29, 2022 15:43
@julienrbrt
Copy link
Member Author

julienrbrt commented Jun 29, 2022

Closing in favor of #12398

@julienrbrt julienrbrt closed this Jun 29, 2022
@julienrbrt julienrbrt deleted the julien/decouple-staking-simapp branch June 29, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate x/staking to use app wiring
1 participant