Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use mocks for x/feegrant testing #12472

Merged
merged 19 commits into from
Jul 13, 2022
Merged

Conversation

facundomedica
Copy link
Member

Description

Ref: #12398


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@facundomedica facundomedica marked this pull request as ready for review July 12, 2022 18:26
@facundomedica facundomedica requested a review from a team as a code owner July 12, 2022 18:26
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, do we need to revert simulation changes

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #12472 (f1b2405) into main (401d17b) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12472      +/-   ##
==========================================
- Coverage   65.29%   65.21%   -0.08%     
==========================================
  Files         694      694              
  Lines       71851    71850       -1     
==========================================
- Hits        46917    46859      -58     
- Misses      22295    22355      +60     
+ Partials     2639     2636       -3     
Impacted Files Coverage Δ
x/feegrant/keeper/keeper.go 79.14% <ø> (-1.79%) ⬇️
x/feegrant/keeper/migrations.go 0.00% <0.00%> (-50.00%) ⬇️
x/feegrant/module/module.go 13.48% <0.00%> (-31.47%) ⬇️
x/feegrant/genesis.go 0.00% <0.00%> (-16.67%) ⬇️
x/distribution/simulation/operations.go 80.85% <0.00%> (-9.58%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️

@facundomedica
Copy link
Member Author

lgtm, do we need to revert simulation changes

No, those changes are ok. I removed some dependencies and stopped using the staking keeper which was there for no good reason

@facundomedica facundomedica merged commit a2000ff into main Jul 13, 2022
@facundomedica facundomedica deleted the facu/feegrant-mocks branch July 13, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants