-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace keyring module to zondax's fork #12938
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12938 +/- ##
==========================================
- Coverage 55.87% 55.71% -0.17%
==========================================
Files 646 646
Lines 54895 54861 -34
==========================================
- Hits 30675 30564 -111
- Misses 21762 21844 +82
+ Partials 2458 2453 -5
|
Just curious, are we going to keep using zondax's fork or these changes will be upstreamed in |
Should we also backport this to 0.45 @marbar3778 @AmauryM? |
According to what I talked with Marko, would be better to update the cosmos' fork of |
Description
Closes: #10220
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change