Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proper error when parsing telemetry configuration (backport #12981) #12999

Merged
merged 2 commits into from
Aug 23, 2022
Merged

fix: proper error when parsing telemetry configuration (backport #12981) #12999

merged 2 commits into from
Aug 23, 2022

Commits on Aug 23, 2022

  1. fix: proper error when parsing telemetry configuration (#12981) 

    When parsing `telemetry.global-labels` config the code assumes that the type will be an array.  I saw an issue where someone edited the configuration in the wrong way and got the following error:
![photo_2022-08-21_08-02-21](https://user-images.githubusercontent.com/22855163/185793842-c5759a54-1860-4dd1-bdb4-b94f4dab3c16.jpg)
Instead, I suggest here to print a proper error log to indicate what the issue is.

(cherry picked from commit c24c439)

# Conflicts:
#	server/start.go
    @liorbond @mergify
    liorbond authored and mergify[bot] committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    ed19ee0 View commit details
    Browse the repository at this point in the history

  2. updates

    @julienrbrt
    julienrbrt committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    b47665f View commit details
    Browse the repository at this point in the history