fix: ensure withdraw_rewards events are always emitted on reward withdrawal (backport #13323) #13340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
julienrbrt
approved these changes
Sep 20, 2022
julienrbrt
force-pushed
the
mergify/bp/release/v0.45.x/pr-13323
branch
from
21dc5bf
to
a663638
Compare
julienrbrt
reviewed
Sep 20, 2022
| ### Improvements | ||
|
|
||
| * [#13323](https://github.com/cosmos/cosmos-sdk/pull/13323) Ensure `withdraw_rewards` rewards are emitted from all actions that result in rewards being withdrawn. | ||
| * [#13321](https://github.com/cosmos/cosmos-sdk/pull/13321) Add flag to disable fast node migration and usage. |
tac0turtle
approved these changes
Sep 20, 2022
tac0turtle
reviewed
Oct 12, 2022
Comment on lines
+191
to
+200
| if finalRewards.IsZero() { | ||
| baseDenom, _ := sdk.GetBaseDenom() | ||
| if baseDenom == "" { | ||
| baseDenom = sdk.DefaultBondDenom | ||
| } | ||
|
|
||
| // Note, we do not call the NewCoins constructor as we do not want the zero | ||
| // coin removed. | ||
| finalRewards = sdk.Coins{sdk.NewCoin(baseDenom, sdk.ZeroInt())} | ||
| } |
There was a problem hiding this comment.
@alexanderbez I think this is state breaking? can we remove since it was out of scope of the pr
There was a problem hiding this comment.
Discussed out of band. Assured that this is not state machine breaking as it:
- Adds new events
- Moves existing SM logic from one method to another.
yun-yeo
added a commit
to terra-money/cosmos-sdk
that referenced
this pull request
Oct 14, 2022
Merged
19 tasks
5 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #13323 done by Mergify.
Cherry-pick of c1c23a7 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com