Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix simulations failure #13512

Merged
merged 3 commits into from
Oct 12, 2022
Merged

fix: fix simulations failure #13512

merged 3 commits into from
Oct 12, 2022

Conversation

julienrbrt
Copy link
Member

Description

Fixes the simulations failure: https://github.com/cosmos/cosmos-sdk/actions/runs/3229864440/jobs/5287681195

You can verify with the following command, as CI skips that test.

cd simapp
go test . -run TestAppImportExport -Enabled=true -NumBlocks=2 -Genesis= -Verbose=true -Commit=true -Seed=2 -Period=5 -ExportParamsPath /tmp/sim-logs-983113732/sim_params-1.json -ExportStatePath /tmp/sim-logs-983113732/sim_state-1.json -v -timeout 24h

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner October 11, 2022 22:15
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #13512 (979c3f5) into main (e5e97c3) will decrease coverage by 0.29%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13512      +/-   ##
==========================================
- Coverage   54.10%   53.81%   -0.30%     
==========================================
  Files         650      653       +3     
  Lines       55855    56830     +975     
==========================================
+ Hits        30223    30585     +362     
- Misses      23208    23799     +591     
- Partials     2424     2446      +22     
Impacted Files Coverage Δ
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
x/staking/simulation/operations.go 74.54% <0.00%> (-1.38%) ⬇️
tx/textual/valuerenderer/duration.go
tx/textual/valuerenderer/int.go
tx/textual/valuerenderer/valuerenderer.go
tx/textual/valuerenderer/timestamp.go
tx/textual/valuerenderer/dec.go
tx/textual/valuerenderer/bytes.go
tx/textual/valuerenderer/coins.go
simapp/upgrades.go 28.57% <0.00%> (ø)
... and 9 more

@julienrbrt julienrbrt enabled auto-merge (squash) October 12, 2022 07:10
@julienrbrt julienrbrt merged commit 4014953 into main Oct 12, 2022
@julienrbrt julienrbrt deleted the julien/sims branch October 12, 2022 07:24
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants