Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump go and remove buildjet #13674

Merged
merged 12 commits into from
Oct 27, 2022
Merged

ci: bump go and remove buildjet #13674

merged 12 commits into from
Oct 27, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 27, 2022

Description


Leaving this at draft first, so we can compare the actual run time.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #13674 (274d907) into main (6b4db20) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 274d907 differs from pull request most recent head bb9b9bc. Consider uploading reports for the commit bb9b9bc to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13674      +/-   ##
==========================================
- Coverage   54.80%   54.69%   -0.11%     
==========================================
  Files         647      657      +10     
  Lines       55794    57158    +1364     
==========================================
+ Hits        30579    31265     +686     
- Misses      22724    23362     +638     
- Partials     2491     2531      +40     
Impacted Files Coverage Δ
simapp/app.go 77.84% <ø> (ø)
client/tx/factory.go 29.21% <100.00%> (+0.80%) ⬆️
simapp/genesis.go 100.00% <0.00%> (ø)
simapp/simd/cmd/testnet.go 61.98% <0.00%> (ø)
simapp/simd/cmd/genaccounts.go 89.09% <0.00%> (ø)
simapp/export.go 11.94% <0.00%> (ø)
simapp/state.go 0.00% <0.00%> (ø)
simapp/test_helpers.go 30.25% <0.00%> (ø)
simapp/simd/cmd/root.go 70.23% <0.00%> (ø)
... and 3 more

@julienrbrt julienrbrt marked this pull request as ready for review October 27, 2022 13:49
@julienrbrt julienrbrt requested a review from a team as a code owner October 27, 2022 13:49
@julienrbrt julienrbrt merged commit fc38dc2 into main Oct 27, 2022
@julienrbrt julienrbrt deleted the julien/ci branch October 27, 2022 13:55
@julienrbrt
Copy link
Member Author

julienrbrt commented Nov 1, 2022

The Slack notification didn't work for 0.46.4 because I didn't backport this 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants