Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract MockTendermintRPC to testutil/cli #13749

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Nov 3, 2022

Description

ref: #13692 (comment)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner November 3, 2022 18:15
@julienrbrt julienrbrt changed the title refactor: extract tendermint CLI to testutil/cli refactor: extract MockTendermintRPC to testutil/cli Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #13749 (5e12ec9) into main (779c0ac) will increase coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13749      +/-   ##
==========================================
+ Coverage   56.05%   56.15%   +0.09%     
==========================================
  Files         646      655       +9     
  Lines       55790    56195     +405     
==========================================
+ Hits        31271    31554     +283     
- Misses      21979    22065      +86     
- Partials     2540     2576      +36     
Impacted Files Coverage Δ
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
x/staking/simulation/operations.go 74.54% <0.00%> (-1.38%) ⬇️
tx/textual/valuerenderer/timestamp.go 89.28% <0.00%> (ø)
tx/textual/valuerenderer/duration.go 78.22% <0.00%> (ø)
tx/textual/valuerenderer/string.go 66.66% <0.00%> (ø)
tx/textual/valuerenderer/bytes.go 62.50% <0.00%> (ø)
tx/textual/valuerenderer/message.go 64.22% <0.00%> (ø)
tx/textual/valuerenderer/dec.go 50.00% <0.00%> (ø)
tx/textual/valuerenderer/coins.go 73.17% <0.00%> (ø)
tx/textual/valuerenderer/valuerenderer.go 72.41% <0.00%> (ø)
... and 1 more

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup

@julienrbrt julienrbrt enabled auto-merge (squash) November 3, 2022 21:42
@julienrbrt julienrbrt merged commit 08be7ee into main Nov 3, 2022
@julienrbrt julienrbrt deleted the julien/refactor-tm-mock branch November 3, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants