feat(app): Update post handlers to incorporate the `runMsg` success bool #13940

fedekunze · 2022-11-21T10:11:20Z

Description

Closes: #XXXX

Updates the post handler to incorporate a success boolean. This enables use cases like refunding unused gas during failed txs.

type PostHandler func(ctx Context, tx Tx, simulate, success bool) (newCtx Context, err error)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

…mos-sdk into fedekunze/update-posthandlers

codecov · 2022-11-21T10:39:37Z

Codecov Report

Merging #13940 (99b69d5) into main (2739f83) will increase coverage by 0.00%.
The diff coverage is 46.42%.

❗ Current head 99b69d5 differs from pull request most recent head 1ded094. Consider uploading reports for the commit 1ded094 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #13940   +/-   ##
=======================================
  Coverage   56.25%   56.26%           
=======================================
  Files         667      664    -3     
  Lines       56576    56510   -66     
=======================================
- Hits        31829    31797   -32     
+ Misses      22165    22142   -23     
+ Partials     2582     2571   -11

Impacted Files	Coverage Δ
baseapp/baseapp.go	`76.76% <0.00%> (ø)`
testutil/mock/types_handler.go	`0.00% <0.00%> (ø)`
baseapp/options.go	`66.12% <100.00%> (ø)`
types/handler.go	`100.00% <100.00%> (ø)`
x/group/module/module.go	`48.05% <0.00%> (-0.10%)`	⬇️
server/mock/tx.go	`53.33% <0.00%> (ø)`
x/auth/types/codec.go	`100.00% <0.00%> (ø)`
x/group/keeper/migrations.go
x/auth/types/credentials.go
x/group/migrations/v2/migrate.go
... and 3 more

types/handler.go

aaronc

I think we should be careful about what gets exposed to post handlers. I don't want to encourage inspecting Msg results here as that could lead to skipping pathways like authz, gov, cosmwasm, ICA etc. If there are handlers that inspect Msg's and their results, we should add ante and post handlers to MsgServiceRouter so they don't get skipped by alternate pathways. So post handlers should be limited to stuff related to just transcation processing. What data is actually needed for something like refunding gas?

fedekunze · 2022-11-21T19:43:10Z

I don't want to encourage inspecting Msg results here as that could lead to skipping pathways like authz, gov, cosmwasm, ICA etc.

This is behavior is optional per app and doesn't need to be implemented on the SDK. This is to support full leftover gas refunds in case the transaction fails

What actual data is needed from Result to accomplish something like refunding gas?

@aaronc the leftover gas is included in the tx result. It can also be obtained from the ctx gas meter but in general inspecting the result can enable post-processing logic that is more customizable

sonarcloud · 2022-11-21T19:55:57Z

[Cosmos SDK] SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

36.8% Coverage
0.0% Duplication

types/handler.go

kocubinski

Question about PostHandler signature and usage.

baseapp/baseapp.go

fedekunze · 2023-01-03T21:03:39Z

@cosmos/sdk-core-review could you take a look again at this PR?

aaronc

This specifically passes the message results into the post handler which is what we want to avoid so there isn't some post handling logic on messages that gets skipped by authz, gov, etc. Can the post handler just get info on whether the tx was successful and the necessary info on gas and fees?

amaury1093

LGTM

CHANGELOG.md

Co-authored-by: Amaury <[email protected]>

@mbreithecker

* chore: bump tendermint to 0.34.24 (cosmos#13972) * chore: add group and gov/v1 in swagger (backport cosmos#13984) (cosmos#13996) * chore: add group and gov/v1 in swagger (cosmos#13984) Co-authored-by: Marko <[email protected]> (cherry picked from commit cfa224c) # Conflicts: # client/docs/config.json # client/docs/swagger-ui/swagger.yaml * updates Co-authored-by: Julien Robert <[email protected]> * fix(baseapp): fix snapshot interval bug (backport cosmos#14049) (cosmos#14053) * refactor: use viper unmarshal in `config.GetConfig` function (backport cosmos#13651) (cosmos#14082) * fix(group)!: Don't re-tally proposals after VP end (backport cosmos#14071) (cosmos#14091) * fix(group)!: Don't re-tally proposals after VP end (cosmos#14071) (cherry picked from commit 4ebe3aa) # Conflicts: # CHANGELOG.md * fix changelog and test Co-authored-by: Amaury <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: do not shadow clientCtx in start.go (backport cosmos#14086) (cosmos#14101) * fix: do not shadow clientCtx in start.go (cosmos#14086) (cherry picked from commit f96072d) # Conflicts: # server/start.go * updates Co-authored-by: Julien Robert <[email protected]> * chore: Test for Server Config Read cosmos#14125 (cosmos#14127) (cherry picked from commit 9f46665) Co-authored-by: Aleksandr Bezobchuk <[email protected]> * fix: remove duplicate ante events (backport cosmos#13983) (cosmos#14142) * fix: remove duplicate ante events (cosmos#13983) ## Description After enabling the post-handler on our chain, we realised something odd with our transaction events. The ordering was `[ANTE, MSGS, ANTE, POST]`. After doing some digging, we realised that the context used inside the post-handler still contains the events from the ante-handler. This should be backported to v0.46.x and v0.47.x 😄 Happy to make it compatible with cosmos#13940 when that gets merged! cc @mbreithecker --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 25449b5) # Conflicts: # CHANGELOG.md * fix changelog Co-authored-by: John Letey <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat: support alternative query multistore (backport cosmos#13529) (cosmos#14169) * feat: support alternative query multistore (cosmos#13529) * support customize query multistore * Update CHANGELOG.md * fix test * Update baseapp/abci.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Update baseapp/baseapp.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Update baseapp/options.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Apply suggestions from code review Co-authored-by: Marko <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> (cherry picked from commit 15accd7) # Conflicts: # CHANGELOG.md # baseapp/baseapp.go # baseapp/options.go * fix conflicts Co-authored-by: yihuang <[email protected]> * fix: state listener observe writes at wrong time (backport cosmos#13516) (cosmos#14138) * fix: state listener observe writes at wrong time (cosmos#13516) * fix: state listener observe writes at wrong time Closes: cosmos#13457 Currently state listener is notified when the cache store write, which happens in commit event only, which breaks the current design. The solution (as discussed in the issue) is to listen state writes on rootmulti store only. It also changes the file streamer to output single data file for the writes in the whole block, since we can't distinguish writes from different stage of abci events. It adds new config items for file streamer: - streamers.file.output-metadata - streamers.file.stop-node-on-error - streamers.file.fsync * synchronous abci call, and format doc * fix comment * update file streamer readme and fix typos * typo * fix: state listener observe writes at wrong time Closes: cosmos#13457 Currently state listener is notified when the cache store write, which happens in commit event only, which breaks the current design. The solution (as discussed in the issue) is to listen state writes on rootmulti store only. It also changes the file streamer to output single data file for the writes in the whole block, since we can't distinguish writes from different stage of abci events. It adds new config items for file streamer: - streamers.file.output-metadata - streamers.file.stop-node-on-error - streamers.file.fsync synchronous abci call, and format doc fix comment update file streamer readme and fix typos typo * improve UX of file streamer, make it immediately usable after enabled - set default value to write_dir. - make write_dir based on home directory by default. - auto-create the directory if not exists. * get homePage from opts Co-authored-by: Marko <[email protected]> (cherry picked from commit 1f91ee2) # Conflicts: # CHANGELOG.md # api/cosmos/base/store/v1beta1/listening.pulsar.go # baseapp/streaming.go # docs/architecture/adr-038-state-listening.md # server/config/toml.go # simapp/app_v2.go # store/cachemulti/store.go # store/iavl/store.go # store/mem/store.go # store/streaming/constructor.go # store/streaming/file/service.go # store/streaming/file/service_test.go # store/types/listening.pb.go # store/types/store.go * `make proto-gen`, update changelog, delete uncessary files * fix conflicts * fix conflicts * revert api breaking change * fix build * fix unit test Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Marko <[email protected]> * refactor: provide a helper for baseapp options (backport cosmos#14175) (cosmos#14178) * refactor: provide a helper for baseapp options (cosmos#14175) * provide a helper for baseapp options * rename * changelog entry * fix spelling (cherry picked from commit 1b6192f) # Conflicts: # CHANGELOG.md # server/mock/app_test.go # simapp/simd/cmd/root.go * conflicts * lint Co-authored-by: Marko <[email protected]> * feat: add --grpc client option (backport cosmos#14051) (cosmos#14192) Co-authored-by: Aaron Craelius <[email protected]> Co-authored-by: Julien Robert <[email protected]> * refactor: cleanup store/streaming/constructor.go (backport cosmos#14044) (cosmos#14236) * chore: audit store/streaming/file/service.go (backport cosmos#14234) (cosmos#14241) Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: fix grpc flag conflict (backport cosmos#14244) (cosmos#14248) * chore: prepare 0.46.7 release (cosmos#14103) * fix(gov): Fix v3 votes migrations (backport cosmos#14214) (cosmos#14277) Co-authored-by: Amaury <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Amaury <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: John Letey <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Aaron Craelius <[email protected]>

sonarcloud · 2023-01-11T17:32:29Z

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

81.8% Coverage
0.0% Duplication

…ool (#13940) Co-authored-by: MalteHerrmann <[email protected]> Co-authored-by: Vladislav Varadinov <[email protected]> Co-authored-by: Amaury <[email protected]> (cherry picked from commit 551e8f9) # Conflicts: # CHANGELOG.md

julienrbrt · 2023-01-13T09:38:13Z

baseapp/baseapp.go

-			// The runMsgCtx context currently contains events emitted by the ante handler.
-			// We clear this to correctly order events without duplicates.
-			// Note that the state is still preserved.
-			postCtx := runMsgCtx.WithEventManager(sdk.NewEventManager())


Is it not a regression of #13983 to remove this?

Seems like this was deleted by mistake, will address in another PR. #14613

…ool (backport #13940) (#14586) Co-authored-by: Federico Kunze Küllmer <[email protected]>

@mbreithecker

* Revert "Merge pull request #270 from provenance-io/llama/add-fee-denom-change-proposal" This reverts commit 7462a84, reversing changes made to 23ba5dc. * Bring in v0.46.4 changes. (#362) * docs: add ApplicationQueryService release notes (cosmos#13587) * docs: add ApplicationQueryService release notes * updates Co-authored-by: Julien Robert <[email protected]> * feat(cli): add module-account cli cmd and grpc get api (backport cosmos#13612) (cosmos#13616) * feat(cli): add module-account cli cmd and grpc get api (cosmos#13612) (cherry picked from commit ddf5cf0) # Conflicts: # CHANGELOG.md # api/cosmos/auth/v1beta1/query.pulsar.go # api/cosmos/auth/v1beta1/query_grpc.pb.go # x/auth/client/testutil/suite.go # x/auth/types/query.pb.go * fix conflicts * updates * updates Co-authored-by: Sai Kumar <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/auth): allow multiple = signs in `GetTxsEvent` (backport cosmos#12474) (cosmos#13598) * fix(x/auth): allow multiple = signs in `GetTxsEvent` (cosmos#12474) (cherry picked from commit 18da0e9) # Conflicts: # CHANGELOG.md * fix changelog * changelog * fix: flakey test Co-authored-by: Tyler <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: app-hash mismatch if upgrade migration commit is interrupted (backport cosmos#13530) (cosmos#13627) * feat(cli): Add iavl-disable-fastnode cmd flag with proper description (cosmos#13656) (cosmos#13659) (cherry picked from commit c833190) Co-authored-by: William Chong <[email protected]> * build(deps): Bump github.com/cosmos/iavl from 0.19.3 to 0.19.4 (cosmos#13680) * feat: emit cached context events (backport cosmos#13063) (cosmos#13702) * chore: prepare 0.46.4 changelog (cosmos#13716) * chore: prepare 0.46.4 changelog * wording * updates * updates * Change the default for the iavl-disable-fastnode flag to true (from false) to match the actual config default. * Add changelog entry for the iavl fastnode flag default. * Update swagger docs. Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Sai Kumar <[email protected]> Co-authored-by: Tyler <[email protected]> Co-authored-by: William Chong <[email protected]> * Mark v0.46.4-pio-1 in the changelog and release notes. * Bring in v0.46.5 changes. (#365) * Bring in changes from Cosmos-SDK v0.46.6 (#367) * docs: add ApplicationQueryService release notes (cosmos#13587) * docs: add ApplicationQueryService release notes * updates Co-authored-by: Julien Robert <[email protected]> * feat(cli): add module-account cli cmd and grpc get api (backport cosmos#13612) (cosmos#13616) * feat(cli): add module-account cli cmd and grpc get api (cosmos#13612) (cherry picked from commit ddf5cf0) # Conflicts: # CHANGELOG.md # api/cosmos/auth/v1beta1/query.pulsar.go # api/cosmos/auth/v1beta1/query_grpc.pb.go # x/auth/client/testutil/suite.go # x/auth/types/query.pb.go * fix conflicts * updates * updates Co-authored-by: Sai Kumar <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/auth): allow multiple = signs in `GetTxsEvent` (backport cosmos#12474) (cosmos#13598) * fix(x/auth): allow multiple = signs in `GetTxsEvent` (cosmos#12474) (cherry picked from commit 18da0e9) # Conflicts: # CHANGELOG.md * fix changelog * changelog * fix: flakey test Co-authored-by: Tyler <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: app-hash mismatch if upgrade migration commit is interrupted (backport cosmos#13530) (cosmos#13627) * feat(cli): Add iavl-disable-fastnode cmd flag with proper description (cosmos#13656) (cosmos#13659) (cherry picked from commit c833190) Co-authored-by: William Chong <[email protected]> * build(deps): Bump github.com/cosmos/iavl from 0.19.3 to 0.19.4 (cosmos#13680) * feat: emit cached context events (backport cosmos#13063) (cosmos#13702) * chore: prepare 0.46.4 changelog (cosmos#13716) * chore: prepare 0.46.4 changelog * wording * updates * updates * ci: notify for 0.46.x releases (cosmos#13719) * feat: notify for 0.46.x releases * updates changelog * docs: fix algolia on 0.46 (cosmos#13730) * ci: modifying docs in 0.46 should not redeploy docs (cosmos#13732) * ci: modifying docs in 0.46 should not redeploy docs * updates * fix: propagate msg events correctly in x/gov (backport cosmos#13728) (cosmos#13748) * refactor: add error log when iavl set failed (backport cosmos#13803) (cosmos#13804) * refactor: add error log when iavl set failed (cosmos#13803) * add error log when iavl set failed Ref: cosmos#12012 * Update CHANGELOG.md * play safe (cherry picked from commit 22f3261) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: yihuang <[email protected]> * chore: bump tendermint to `0.34.23` (cosmos#13814) * fix: propagate events in x/group through sdk.Results (backport cosmos#13808) (cosmos#13809) * docs: update algolia index (cosmos#13823) * fix: bank store migration (backport cosmos#13821) (cosmos#13829) * fix: bank store migration (cosmos#13821) (cherry picked from commit d314a12) # Conflicts: # x/bank/migrations/v3/store.go # x/bank/migrations/v3/store_test.go * updates Co-authored-by: billy rennekamp <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(types): set custom GasConfig on Context for GasKVStore (backport cosmos#13826) (cosmos#13833) * feat(types): set custom GasConfig on Context for GasKVStore (cosmos#13826) (cherry picked from commit f001b46) # Conflicts: # CHANGELOG.md # types/context.go # types/context_test.go * fix conflicts * updates Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: prepare 0.46.5 release (cosmos#13816) * fix: Allow underscores in EventRegex (backport cosmos#13861) (cosmos#13864) * fix: Allow underscores in EventRegex (cosmos#13861) (cherry picked from commit 14c582f) # Conflicts: # CHANGELOG.md # tests/e2e/tx/service_test.go * updates * updates Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(group): add group members weight checks (backport cosmos#13869) (cosmos#13880) * fix(group): add group members weight checks (cosmos#13869) (cherry picked from commit 3423442) # Conflicts: # CHANGELOG.md # api/cosmos/tx/v1beta1/service.pulsar.go # types/tx/service.pb.go # x/group/keeper/keeper.go * fix conflicts * updates * updates Co-authored-by: Julien Robert <[email protected]> * fix(group)!: Fix group min execution period (backport cosmos#13876) (cosmos#13885) * fix(group)!: Fix group min execution period (cosmos#13876) * fix: don't check MinExecutionPeriod in `Allow` * Check MinExecutionPeriod on doExecuteMsgs * Fix TestExec * Fix TestExec * test exec pruned * Fix submitproposal * Add changelog * typo * revert some changes * add minExecutionPeriod * Add docs and specs (cherry picked from commit 7661f62) # Conflicts: # CHANGELOG.md # x/group/README.md # x/group/keeper/keeper_test.go * fix docs * fix other conflicts * fix test Co-authored-by: Amaury <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(bank): Add helper for v0.46 denom migration (cosmos#13891) * feat(bank): Add helper for v0.46 denom migration * CL * Clearer name * Update x/bank/migrations/v046/store.go Co-authored-by: Likhita Polavarapu <[email protected]> * rename Co-authored-by: Likhita Polavarapu <[email protected]> * chore: impove 0.46.5 release notes (cosmos#13898) * chore: impove 0.46.5 release notes * update changelog * refactor: State Streaming Docs + Explicit Config Support (backport cosmos#13894) (cosmos#13909) * chore: remove typo (cosmos#13914) (cosmos#13917) (cherry picked from commit 34dcca7) Co-authored-by: Julien Robert <[email protected]> * fix: correctly propagate msg errors in gov (backport cosmos#13918) (cosmos#13928) * fix: correctly propagate msg errors in gov (cosmos#13918) * fix: correctly propagate msg errors in gov * chore: update changelog * fix: correctly check proposal status in tests * chore: delete unused var (cherry picked from commit 5581f7f) # Conflicts: # CHANGELOG.md # x/gov/abci_test.go * fix conflicts * updates Co-authored-by: John Letey <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(bank): enable 0.46.5 bank migration fix through migrator keeper (cosmos#13929) * Update changelog for version bump. * Bring in Cosmos-SDK PR 13651 that overhauls/cleans up the GetConfig function to not require manual addition of stuff in order for it to be read. * Fix the pruning command to use the existing viper instance (that has everything loaded into it) instead of creating a new one. Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Sai Kumar <[email protected]> Co-authored-by: Tyler <[email protected]> Co-authored-by: William Chong <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: billy rennekamp <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Amaury <[email protected]> Co-authored-by: Likhita Polavarapu <[email protected]> Co-authored-by: John Letey <[email protected]> * Backport to v0.46.x: feat: Add x/authz SendAuthorization AllowList cosmos#12648 (#368) * feat: Add x/authz SendAuthorization AllowList (cosmos#12648) Closes: cosmos#12609 --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) * Fix a unit test that for whatever reason didn't get updated in the merge. Co-authored-by: likhita-809 <[email protected]> * Mark v0.46.6-pio-1 in the changelog and release notes. * use hashicorp go-plugin * python example * implement streaming to baseapp * abci listener wiring * update test files * update test files * kafka plugin python example * update package name * update proto and services * tx and kvpair indexing * tidy up * add readme * update readme * add testing section * listeners need to be async * remove goroutine on blocking call * terminate with os.Exit on stopNodeOnErr * dumb pipe bridge * fix: listen state writes on rootmulti store only and refactoring file streamer to output single file for each block update spec sort storeKey once at first move MemoryListener store package * introduce memory listener and OnCommit listener * remove WriteListener and use MemoryListener * internalize listener init to cache layer * determenistic PopStateCache, grpc service * add Go file plugin * multiple service support * add \n * add proto dir * append to file * support in-process listeners * use setStreamingService * enable plugins as managed clients * fix after cherry pick * add default to toml config * format toml config * update template * update template * update documentation * fix test * write request to single topics * fix lint errors * remove python examples, CI cannot verify * fix gosec findings * move plugin proto with sdk proto files, regen plugin code * update readme * update deps remove unused dep * Bring in v0.46.7 updates. (#402) * docs: add ApplicationQueryService release notes (cosmos#13587) * docs: add ApplicationQueryService release notes * updates Co-authored-by: Julien Robert <[email protected]> * feat(cli): add module-account cli cmd and grpc get api (backport cosmos#13612) (cosmos#13616) * feat(cli): add module-account cli cmd and grpc get api (cosmos#13612) (cherry picked from commit ddf5cf0) # Conflicts: # CHANGELOG.md # api/cosmos/auth/v1beta1/query.pulsar.go # api/cosmos/auth/v1beta1/query_grpc.pb.go # x/auth/client/testutil/suite.go # x/auth/types/query.pb.go * fix conflicts * updates * updates Co-authored-by: Sai Kumar <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/auth): allow multiple = signs in `GetTxsEvent` (backport cosmos#12474) (cosmos#13598) * fix(x/auth): allow multiple = signs in `GetTxsEvent` (cosmos#12474) (cherry picked from commit 18da0e9) # Conflicts: # CHANGELOG.md * fix changelog * changelog * fix: flakey test Co-authored-by: Tyler <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: app-hash mismatch if upgrade migration commit is interrupted (backport cosmos#13530) (cosmos#13627) * feat(cli): Add iavl-disable-fastnode cmd flag with proper description (cosmos#13656) (cosmos#13659) (cherry picked from commit c833190) Co-authored-by: William Chong <[email protected]> * build(deps): Bump github.com/cosmos/iavl from 0.19.3 to 0.19.4 (cosmos#13680) * feat: emit cached context events (backport cosmos#13063) (cosmos#13702) * chore: prepare 0.46.4 changelog (cosmos#13716) * chore: prepare 0.46.4 changelog * wording * updates * updates * ci: notify for 0.46.x releases (cosmos#13719) * feat: notify for 0.46.x releases * updates changelog * docs: fix algolia on 0.46 (cosmos#13730) * ci: modifying docs in 0.46 should not redeploy docs (cosmos#13732) * ci: modifying docs in 0.46 should not redeploy docs * updates * fix: propagate msg events correctly in x/gov (backport cosmos#13728) (cosmos#13748) * refactor: add error log when iavl set failed (backport cosmos#13803) (cosmos#13804) * refactor: add error log when iavl set failed (cosmos#13803) * add error log when iavl set failed Ref: cosmos#12012 * Update CHANGELOG.md * play safe (cherry picked from commit 22f3261) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: yihuang <[email protected]> * chore: bump tendermint to `0.34.23` (cosmos#13814) * fix: propagate events in x/group through sdk.Results (backport cosmos#13808) (cosmos#13809) * docs: update algolia index (cosmos#13823) * fix: bank store migration (backport cosmos#13821) (cosmos#13829) * fix: bank store migration (cosmos#13821) (cherry picked from commit d314a12) # Conflicts: # x/bank/migrations/v3/store.go # x/bank/migrations/v3/store_test.go * updates Co-authored-by: billy rennekamp <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(types): set custom GasConfig on Context for GasKVStore (backport cosmos#13826) (cosmos#13833) * feat(types): set custom GasConfig on Context for GasKVStore (cosmos#13826) (cherry picked from commit f001b46) # Conflicts: # CHANGELOG.md # types/context.go # types/context_test.go * fix conflicts * updates Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: prepare 0.46.5 release (cosmos#13816) * fix: Allow underscores in EventRegex (backport cosmos#13861) (cosmos#13864) * fix: Allow underscores in EventRegex (cosmos#13861) (cherry picked from commit 14c582f) # Conflicts: # CHANGELOG.md # tests/e2e/tx/service_test.go * updates * updates Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(group): add group members weight checks (backport cosmos#13869) (cosmos#13880) * fix(group): add group members weight checks (cosmos#13869) (cherry picked from commit 3423442) # Conflicts: # CHANGELOG.md # api/cosmos/tx/v1beta1/service.pulsar.go # types/tx/service.pb.go # x/group/keeper/keeper.go * fix conflicts * updates * updates Co-authored-by: Julien Robert <[email protected]> * fix(group)!: Fix group min execution period (backport cosmos#13876) (cosmos#13885) * fix(group)!: Fix group min execution period (cosmos#13876) * fix: don't check MinExecutionPeriod in `Allow` * Check MinExecutionPeriod on doExecuteMsgs * Fix TestExec * Fix TestExec * test exec pruned * Fix submitproposal * Add changelog * typo * revert some changes * add minExecutionPeriod * Add docs and specs (cherry picked from commit 7661f62) # Conflicts: # CHANGELOG.md # x/group/README.md # x/group/keeper/keeper_test.go * fix docs * fix other conflicts * fix test Co-authored-by: Amaury <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(bank): Add helper for v0.46 denom migration (cosmos#13891) * feat(bank): Add helper for v0.46 denom migration * CL * Clearer name * Update x/bank/migrations/v046/store.go Co-authored-by: Likhita Polavarapu <[email protected]> * rename Co-authored-by: Likhita Polavarapu <[email protected]> * chore: impove 0.46.5 release notes (cosmos#13898) * chore: impove 0.46.5 release notes * update changelog * refactor: State Streaming Docs + Explicit Config Support (backport cosmos#13894) (cosmos#13909) * chore: remove typo (cosmos#13914) (cosmos#13917) (cherry picked from commit 34dcca7) Co-authored-by: Julien Robert <[email protected]> * fix: correctly propagate msg errors in gov (backport cosmos#13918) (cosmos#13928) * fix: correctly propagate msg errors in gov (cosmos#13918) * fix: correctly propagate msg errors in gov * chore: update changelog * fix: correctly check proposal status in tests * chore: delete unused var (cherry picked from commit 5581f7f) # Conflicts: # CHANGELOG.md # x/gov/abci_test.go * fix conflicts * updates Co-authored-by: John Letey <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(bank): enable 0.46.5 bank migration fix through migrator keeper (cosmos#13929) * chore: bump tendermint to 0.34.24 (cosmos#13972) * chore: add group and gov/v1 in swagger (backport cosmos#13984) (cosmos#13996) * chore: add group and gov/v1 in swagger (cosmos#13984) Co-authored-by: Marko <[email protected]> (cherry picked from commit cfa224c) # Conflicts: # client/docs/config.json # client/docs/swagger-ui/swagger.yaml * updates Co-authored-by: Julien Robert <[email protected]> * fix(baseapp): fix snapshot interval bug (backport cosmos#14049) (cosmos#14053) * refactor: use viper unmarshal in `config.GetConfig` function (backport cosmos#13651) (cosmos#14082) * fix(group)!: Don't re-tally proposals after VP end (backport cosmos#14071) (cosmos#14091) * fix(group)!: Don't re-tally proposals after VP end (cosmos#14071) (cherry picked from commit 4ebe3aa) # Conflicts: # CHANGELOG.md * fix changelog and test Co-authored-by: Amaury <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: do not shadow clientCtx in start.go (backport cosmos#14086) (cosmos#14101) * fix: do not shadow clientCtx in start.go (cosmos#14086) (cherry picked from commit f96072d) # Conflicts: # server/start.go * updates Co-authored-by: Julien Robert <[email protected]> * chore: Test for Server Config Read cosmos#14125 (cosmos#14127) (cherry picked from commit 9f46665) Co-authored-by: Aleksandr Bezobchuk <[email protected]> * fix: remove duplicate ante events (backport cosmos#13983) (cosmos#14142) * fix: remove duplicate ante events (cosmos#13983) ## Description After enabling the post-handler on our chain, we realised something odd with our transaction events. The ordering was `[ANTE, MSGS, ANTE, POST]`. After doing some digging, we realised that the context used inside the post-handler still contains the events from the ante-handler. This should be backported to v0.46.x and v0.47.x 😄 Happy to make it compatible with cosmos#13940 when that gets merged! cc @mbreithecker --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 25449b5) # Conflicts: # CHANGELOG.md * fix changelog Co-authored-by: John Letey <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat: support alternative query multistore (backport cosmos#13529) (cosmos#14169) * feat: support alternative query multistore (cosmos#13529) * support customize query multistore * Update CHANGELOG.md * fix test * Update baseapp/abci.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Update baseapp/baseapp.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Update baseapp/options.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Apply suggestions from code review Co-authored-by: Marko <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> (cherry picked from commit 15accd7) # Conflicts: # CHANGELOG.md # baseapp/baseapp.go # baseapp/options.go * fix conflicts Co-authored-by: yihuang <[email protected]> * fix: state listener observe writes at wrong time (backport cosmos#13516) (cosmos#14138) * fix: state listener observe writes at wrong time (cosmos#13516) * fix: state listener observe writes at wrong time Closes: cosmos#13457 Currently state listener is notified when the cache store write, which happens in commit event only, which breaks the current design. The solution (as discussed in the issue) is to listen state writes on rootmulti store only. It also changes the file streamer to output single data file for the writes in the whole block, since we can't distinguish writes from different stage of abci events. It adds new config items for file streamer: - streamers.file.output-metadata - streamers.file.stop-node-on-error - streamers.file.fsync * synchronous abci call, and format doc * fix comment * update file streamer readme and fix typos * typo * fix: state listener observe writes at wrong time Closes: cosmos#13457 Currently state listener is notified when the cache store write, which happens in commit event only, which breaks the current design. The solution (as discussed in the issue) is to listen state writes on rootmulti store only. It also changes the file streamer to output single data file for the writes in the whole block, since we can't distinguish writes from different stage of abci events. It adds new config items for file streamer: - streamers.file.output-metadata - streamers.file.stop-node-on-error - streamers.file.fsync synchronous abci call, and format doc fix comment update file streamer readme and fix typos typo * improve UX of file streamer, make it immediately usable after enabled - set default value to write_dir. - make write_dir based on home directory by default. - auto-create the directory if not exists. * get homePage from opts Co-authored-by: Marko <[email protected]> (cherry picked from commit 1f91ee2) # Conflicts: # CHANGELOG.md # api/cosmos/base/store/v1beta1/listening.pulsar.go # baseapp/streaming.go # docs/architecture/adr-038-state-listening.md # server/config/toml.go # simapp/app_v2.go # store/cachemulti/store.go # store/iavl/store.go # store/mem/store.go # store/streaming/constructor.go # store/streaming/file/service.go # store/streaming/file/service_test.go # store/types/listening.pb.go # store/types/store.go * `make proto-gen`, update changelog, delete uncessary files * fix conflicts * fix conflicts * revert api breaking change * fix build * fix unit test Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Marko <[email protected]> * refactor: provide a helper for baseapp options (backport cosmos#14175) (cosmos#14178) * refactor: provide a helper for baseapp options (cosmos#14175) * provide a helper for baseapp options * rename * changelog entry * fix spelling (cherry picked from commit 1b6192f) # Conflicts: # CHANGELOG.md # server/mock/app_test.go # simapp/simd/cmd/root.go * conflicts * lint Co-authored-by: Marko <[email protected]> * feat: add --grpc client option (backport cosmos#14051) (cosmos#14192) Co-authored-by: Aaron Craelius <[email protected]> Co-authored-by: Julien Robert <[email protected]> * refactor: cleanup store/streaming/constructor.go (backport cosmos#14044) (cosmos#14236) * chore: audit store/streaming/file/service.go (backport cosmos#14234) (cosmos#14241) Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: fix grpc flag conflict (backport cosmos#14244) (cosmos#14248) * chore: prepare 0.46.7 release (cosmos#14103) * fix(gov): Fix v3 votes migrations (backport cosmos#14214) (cosmos#14277) Co-authored-by: Amaury <[email protected]> Co-authored-by: Julien Robert <[email protected]> * Add changelog entry for bringing in v0.46.7 changes. * Fix the changelog. The merge duplicated several SDK sections. * Fix the TestFileStreamingService. Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Sai Kumar <[email protected]> Co-authored-by: Tyler <[email protected]> Co-authored-by: William Chong <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: billy rennekamp <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Amaury <[email protected]> Co-authored-by: Likhita Polavarapu <[email protected]> Co-authored-by: John Letey <[email protected]> Co-authored-by: John Letey <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Aaron Craelius <[email protected]> * Mark v0.46.7-pio-1 in the changelog and release notes. * Note v0.46.6-pio-3 in the changelog. * cherry-pick cosmos-sdk authz validatebasic fix (#429) * cherry-pick cosmos-sdk authz validatebasic fix * Add change log entry Co-authored-by: bruce-wayne2 <[email protected]> * set res for delivertx * Revert "Revert "Merge pull request #270 from provenance-io/llama/add-fee-denom-change-proposal"" This reverts commit 648ae0c. * Mark v0.46.8-pio-1 in the changelog and release notes. * improvements from upstream feedback * fix tests * remove release notes * add changelog entry * changes based on feedback * fix tests * default to empty keys * feadback fixes --------- Co-authored-by: Daniel Wedul <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Sai Kumar <[email protected]> Co-authored-by: Tyler <[email protected]> Co-authored-by: William Chong <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: billy rennekamp <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Amaury <[email protected]> Co-authored-by: Likhita Polavarapu <[email protected]> Co-authored-by: John Letey <[email protected]> Co-authored-by: John Letey <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Aaron Craelius <[email protected]> Co-authored-by: Carlton Hanna <[email protected]> Co-authored-by: bruce-wayne2 <[email protected]>

@mbreithecker

* fix: remove duplicate ante events (cosmos#13983) ## Description After enabling the post-handler on our chain, we realised something odd with our transaction events. The ordering was `[ANTE, MSGS, ANTE, POST]`. After doing some digging, we realised that the context used inside the post-handler still contains the events from the ante-handler. This should be backported to v0.46.x and v0.47.x 😄 Happy to make it compatible with cosmos#13940 when that gets merged! cc @mbreithecker --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 25449b5) # Conflicts: # CHANGELOG.md * fix changelog Co-authored-by: John Letey <[email protected]> Co-authored-by: Julien Robert <[email protected]>

feat(app): Update post handlers

f4ef9d6

github-actions bot added the C:x/auth label Nov 21, 2022

fedekunze added 4 commits November 21, 2022 11:13

Merge branch 'main' into fedekunze/update-posthandlers

f98a21f

docs

73a85e7

Merge branch 'fedekunze/update-posthandlers' of github.com:cosmos/cos…

2c29db4

…mos-sdk into fedekunze/update-posthandlers

c++

70e44d0

fedekunze marked this pull request as ready for review November 21, 2022 10:25

fedekunze requested a review from a team as a code owner November 21, 2022 10:25

fedekunze added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Nov 21, 2022

fedekunze self-assigned this Nov 21, 2022

fedekunze mentioned this pull request Nov 21, 2022

[DNM] feat(baseapp): refactor runTx #13941

Closed

19 tasks

MalteHerrmann mentioned this pull request Nov 21, 2022

(tests): Add post decorator mocks and tests #13945

Merged

amaury1093 mentioned this pull request Nov 21, 2022

Refactor RunTx for stateful PostHandler logic on failure #13942

Closed

MalteHerrmann and others added 2 commits November 21, 2022 14:35

add post decorator mocks and tests (#13945)

5145420

Merge branch 'main' into fedekunze/update-posthandlers

1ed6c98

ValarDragon reviewed Nov 21, 2022

View reviewed changes

types/handler.go Outdated Show resolved Hide resolved

tac0turtle assigned kocubinski, amaury1093 and aaronc and unassigned fedekunze Nov 21, 2022

aaronc reviewed Nov 21, 2022

View reviewed changes

Merge branch 'main' into fedekunze/update-posthandlers

99b69d5

fedekunze requested review from tac0turtle, alexanderbez and amaury1093 November 22, 2022 12:14

kocubinski reviewed Nov 22, 2022

View reviewed changes

types/handler.go Outdated Show resolved Hide resolved

kocubinski requested changes Nov 22, 2022

View reviewed changes

baseapp/baseapp.go Outdated Show resolved Hide resolved

aaronc reviewed Jan 3, 2023

View reviewed changes

fedekunze and others added 2 commits January 7, 2023 17:04

Merge branch 'main' into fedekunze/update-posthandlers

ff1cdfc

fix: remove MsgResponses from PostHandler (#14522)

6277794

Vvaradinov mentioned this pull request Jan 10, 2023

cherry-pick: update-posthandler commit evmos/cosmos-sdk#2

Merged

19 tasks

amaury1093 approved these changes Jan 10, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

fedekunze and others added 2 commits January 11, 2023 12:28

Update CHANGELOG.md

1e3745f

Co-authored-by: Amaury <[email protected]>

Merge branch 'main' into fedekunze/update-posthandlers

5332380

fedekunze changed the title ~~feat(app): Update post handlers to incorporate the runMsg result~~ feat(app): Update post handlers to incorporate the runMsg success bool Jan 11, 2023

fedekunze requested a review from aaronc January 11, 2023 11:30

fedekunze enabled auto-merge (squash) January 11, 2023 11:40

Merge branch 'main' into fedekunze/update-posthandlers

f51f2af

aaronc approved these changes Jan 11, 2023

View reviewed changes

alexanderbez approved these changes Jan 11, 2023

View reviewed changes

Merge branch 'main' into fedekunze/update-posthandlers

1ded094

fedekunze merged commit 551e8f9 into main Jan 12, 2023

fedekunze deleted the fedekunze/update-posthandlers branch January 12, 2023 09:37

mergify bot mentioned this pull request Jan 12, 2023

feat(app): Update post handlers to incorporate the runMsg success bool (backport #13940) #14586

Merged

This was referenced Jan 12, 2023

Refactor runTx to include PostHandler cases #14592

Closed

refactor(baseapp): handle cases for PostHandler in runTx #14593

Closed

julienrbrt reviewed Jan 13, 2023

View reviewed changes

Vvaradinov mentioned this pull request Jan 13, 2023

fix: add missing postCtx #14613

Merged

19 tasks

julienrbrt pushed a commit that referenced this pull request Jan 13, 2023

feat(app): Update post handlers to incorporate the runMsg success b…

42aa3e1

…ool (backport #13940) (#14586) Co-authored-by: Federico Kunze Küllmer <[email protected]>

facundomedica mentioned this pull request Dec 5, 2023

fix(baseapp)!: postHandler should run regardless of result #18627

Merged

12 tasks

0xstepit mentioned this pull request Jul 1, 2024

chore(cachemulti): add Copy method evmos/cosmos-sdk#52

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(app): Update post handlers to incorporate the `runMsg` success bool #13940

feat(app): Update post handlers to incorporate the `runMsg` success bool #13940

fedekunze commented Nov 21, 2022 •

edited

Loading

codecov bot commented Nov 21, 2022 •

edited

Loading

aaronc left a comment •

edited

Loading

fedekunze commented Nov 21, 2022

sonarcloud bot commented Nov 21, 2022

kocubinski left a comment

fedekunze commented Jan 3, 2023

aaronc left a comment

amaury1093 left a comment

sonarcloud bot commented Jan 11, 2023

julienrbrt Jan 13, 2023

tac0turtle Jan 13, 2023

Vvaradinov Jan 13, 2023 •

edited

Loading

feat(app): Update post handlers to incorporate the runMsg success bool #13940

feat(app): Update post handlers to incorporate the runMsg success bool #13940

Conversation

fedekunze commented Nov 21, 2022 • edited Loading

Description

Author Checklist

Reviewers Checklist

codecov bot commented Nov 21, 2022 • edited Loading

Codecov Report

aaronc left a comment • edited Loading

Choose a reason for hiding this comment

fedekunze commented Nov 21, 2022

sonarcloud bot commented Nov 21, 2022

kocubinski left a comment

Choose a reason for hiding this comment

fedekunze commented Jan 3, 2023

aaronc left a comment

Choose a reason for hiding this comment

amaury1093 left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jan 11, 2023

julienrbrt Jan 13, 2023

Choose a reason for hiding this comment

tac0turtle Jan 13, 2023

Choose a reason for hiding this comment

Vvaradinov Jan 13, 2023 • edited Loading

Choose a reason for hiding this comment

feat(app): Update post handlers to incorporate the `runMsg` success bool #13940

feat(app): Update post handlers to incorporate the `runMsg` success bool #13940

fedekunze commented Nov 21, 2022 •

edited

Loading

codecov bot commented Nov 21, 2022 •

edited

Loading

aaronc left a comment •

edited

Loading

Vvaradinov Jan 13, 2023 •

edited

Loading