Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: cli config with viper consolidation - step 1 #14428

Closed

Conversation

gjermundgaraba
Copy link
Contributor

Description

Closes: #XXXX

The first step of multiple to deal with #9034. As per the discussion there I have tried to limit the PR down, but I was not able to do so without any breaking changes and actually making some meaningful examples of how to use the new setup.

The goal with this PR is to agree on the general approach and get the framework in place to clean up the way we do CLI configuration ("client" and "server").

The next steps would be to rewrite how flags and environmental variables are handled, which would touch a lot of tests that need to set up the ClientContex with Viper in order to function.

The general idea of how this would work can be seen in an initial draft I made here: gjermundgaraba@c2c443e?diff=split#diff-146f73b0327c426deb3126e44f9234c7a6fe190c1bcb4c98ab8366b3485922ed


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 27, 2023
@github-actions github-actions bot closed this Jan 31, 2023
@tac0turtle
Copy link
Member

sorry for not getting to this. @alexanderbez wanna give feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants