refactor!: cli config with viper consolidation - step 1 #14428
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
The first step of multiple to deal with #9034. As per the discussion there I have tried to limit the PR down, but I was not able to do so without any breaking changes and actually making some meaningful examples of how to use the new setup.
The goal with this PR is to agree on the general approach and get the framework in place to clean up the way we do CLI configuration ("client" and "server").
The next steps would be to rewrite how flags and environmental variables are handled, which would touch a lot of tests that need to set up the ClientContex with Viper in order to function.
The general idea of how this would work can be seen in an initial draft I made here: gjermundgaraba@c2c443e?diff=split#diff-146f73b0327c426deb3126e44f9234c7a6fe190c1bcb4c98ab8366b3485922ed
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change