-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor TxSearch #14758
refactor: Refactor TxSearch #14758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK. Pending s/Tendermint/CometBFT and one minor nit in proto.
e2e tests are broken, wont be able to debug this week. Will need to come back to it next week |
I think they just need to be updated to use |
Description
Closes: #14727
Changelog
QueryTxsByEvents
to acceptquery
instead ofevents
GetTxsEventRequest.Events
fieldGetTxsEventRequest.Query
field which will be directly proxied to Tendermint'sTxSearch
RPC method, thus utilizing Tendermint's validation and query semanticsAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change