-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gov): move args in gov new proposal constructor #14782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added
the
backport/v0.47.x
PR scheduled for inclusion in the v0.47's next stable release
label
Jan 25, 2023
amaury1093
reviewed
Jan 25, 2023
amaury1093
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tac0turtle
approved these changes
Jan 25, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
(cherry picked from commit 2b64d74) # Conflicts: # CHANGELOG.md # x/gov/simulation/operations_test.go
alexanderbez
pushed a commit
that referenced
this pull request
Jan 25, 2023
…ser migration (backport #14782) (#14785) Co-authored-by: Julien Robert <[email protected]>
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/v0.47.x
PR scheduled for inclusion in the v0.47's next stable release
C:Simulations
C:x/gov
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed, it makes more sense to have the 3 strings next to each other (after the addition of title and summary).
As I am doing this for v0.48 here: #14720, it makes sense to do that already for v0.47. So the API break is minimum for v0.48 afterward.
Note: in the backported PR to v0.47.x, we have to cherry-pick the proposer migration from https://github.com/cosmos/cosmos-sdk/pull/13010/files#diff-84dd4933b673594c4303f0a35d9cd93810c49b39a25779abaeb326ebbc34f02fR14.
ref: https://github.com/cosmos/cosmos-sdk/pull/13010/files#r1059373460
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change