Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump btcd in v0.46 #14846

Merged
merged 12 commits into from
Feb 7, 2023
Merged

build(deps): bump btcd in v0.46 #14846

merged 12 commits into from
Feb 7, 2023

Conversation

robert-zaremba
Copy link
Collaborator

Description

Closes: #14845

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba requested a review from a team as a code owner January 30, 2023 19:49
@robert-zaremba robert-zaremba changed the base branch from main to release/v0.46.x January 30, 2023 19:49
@robert-zaremba
Copy link
Collaborator Author

Tendermint should be updated as well.

@julienrbrt julienrbrt changed the title Robert/btcd deps: bump btcd in v0.46 Jan 31, 2023
@julienrbrt julienrbrt marked this pull request as draft January 31, 2023 18:28
@yihuang yihuang mentioned this pull request Feb 1, 2023
Closed
@yihuang
Copy link
Collaborator

yihuang commented Feb 7, 2023

seems to work now? @robert-zaremba

@yihuang yihuang marked this pull request as ready for review February 7, 2023 06:52
@yihuang yihuang marked this pull request as draft February 7, 2023 07:19
julienrbrt and others added 3 commits February 7, 2023 16:11
@julienrbrt @yihuang
refactor: update crypto/ledger to btcec/v2 (#14123)
9e5eae5 
* chore(crypto): update crypto/ledger to v2

* go mod tidy

* updates

* add comment
@elias-orijtech @tac0turtle @yihuang
chore(crypto): update btcec to v2 (#13513)
c6efab6 
Similar to Tendermint's PR,

tendermint/tendermint#9250

Note that crypto/ledger is not updated in this PR, because if its
dependency on the R and S values being exposed by ParseDERSignature.

Updates #13423

Signed-off-by: Elias Naur <[email protected]>

Signed-off-by: Elias Naur <[email protected]>
Co-authored-by: Marko <[email protected]>
@yihuang
reduce tendermint dependency (partial backport #14616)
f0e78ed
@yihuang
Copy link
Collaborator

yihuang commented Feb 7, 2023

seems to work now? @robert-zaremba

now it seems to work, manually backported two PRs.

@yihuang yihuang marked this pull request as ready for review February 7, 2023 08:35
@julienrbrt julienrbrt changed the title deps: bump btcd in v0.46 build(deps): bump btcd in v0.46 Feb 7, 2023
@julienrbrt
Copy link
Member

Thank you both! Testing with a ledger again.

julienrbrt
julienrbrt approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

testinginprod
testinginprod approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@julienrbrt julienrbrt merged commit 0b64514 into release/v0.46.x Feb 7, 2023
@julienrbrt julienrbrt deleted the robert/btcd branch February 7, 2023 10:52
@julienrbrt julienrbrt mentioned this pull request Feb 7, 2023
Closed
@robert-zaremba
Copy link
Collaborator Author

Thanks for fixing the unit test @yihuang

@fedekunze fedekunze mentioned this pull request Feb 9, 2023
Merged
19 tasks
SpicyLemon added a commit to provenance-io/cosmos-sdk that referenced this pull request Feb 16, 2023
@SpicyLemon @mergify
@likhita-809 @yihuang @julienrbrt @tac0turtle @mmsqe @robert-zaremba @elias-orijtech @facundomedica
Backport: #505 (v0.46.9) #517 (v0.46.10) and #510 (sanction Tx CLI) (#…
cf6f99f 
…518)

* fix: Fix Evidence CLI query flag parsing (backport cosmos#13458) (cosmos#14799)

Co-authored-by: Likhita Polavarapu <[email protected]>
Co-authored-by: HuangYi <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix: nested iterator on cache store (cosmos#14798)

* chore: update IAVL  (backport cosmos#14830) (cosmos#14835)

Co-authored-by: Marko <[email protected]>

* Mark v0.46.8-pio-2 in the changelog and release notes.

* feat: add config `iavl-lazy-loading` to enable lazy loading of iavl store (backport cosmos#14189) (cosmos#14862)

Co-authored-by: yihuang <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* chore: bump IAVL to v0.19.5 (backport cosmos#14889) (cosmos#14892)

Co-authored-by: Julien Robert <[email protected]>

* build(deps): bump tendermint to v0.34.25 (cosmos#14903)

* build(deps): bump tendermint to v0.34.26 (cosmos#14911)

* fix: return named error for write validators (backport cosmos#14919) (cosmos#14921)

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* Bump Tendermint to v0.34.25 (from v0.34.24). (#498)

* Fix a few listener proto comments. (#499)

* build(deps): bump btcd in v0.46 (cosmos#14846)

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Elias Naur <[email protected]>
Co-authored-by: Marko <[email protected]>

* ci: update release slack channel and algolia api key (backport cosmos#14942) (cosmos#14945)

Co-authored-by: Julien Robert <[email protected]>

* feat: support profiling block replay during abci handshake (backport cosmos#14953) (cosmos#14964)

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* Revert "Revert cosmos#14349 - cache iterator optimizations (#444)"

This reverts commit cd9d192.

* Mark v0.46.8-pio-3 in the changelog and release notes.

* fix: avoid broadcasting tx through query (backport cosmos#15044) (cosmos#15047)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* Add CLI commands for sanction Tx gov props (#510)

* Fix the changelog.

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Likhita Polavarapu <[email protected]>
Co-authored-by: HuangYi <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Marko <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Elias Naur <[email protected]>
Co-authored-by: Facundo Medica <[email protected]>
@julienrbrt
Copy link
Member

@Mergifyio backport release/v0.45.x

@mergify
Copy link
Contributor

mergify bot commented Feb 22, 2023 •
edited
Loading

backport release/v0.45.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 22, 2023
@robert-zaremba @mergify
build(deps): bump btcd in v0.46 (#14846)
67b2597 
Co-authored-by: yihuang <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Elias Naur <[email protected]>
Co-authored-by: Marko <[email protected]>
(cherry picked from commit 0b64514)

# Conflicts:
#	CHANGELOG.md
#	go.mod
#	go.sum
#	server/rosetta/converter.go
@mergify mergify bot mentioned this pull request Feb 22, 2023
Merged
julienrbrt added a commit that referenced this pull request Feb 22, 2023
@mergify @robert-zaremba @julienrbrt
build(deps): bump btcd in v0.45 (backport #14846) (#15127)
3a48354 
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
ankurdotb pushed a commit to cheqd/cosmos-sdk that referenced this pull request Feb 28, 2023
@robert-zaremba @yihuang
@julienrbrt @elias-orijtech @tac0turtle @ankurdotb
build(deps): bump btcd in v0.46 (cosmos#14846)
2336aea 
Co-authored-by: yihuang <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Elias Naur <[email protected]>
Co-authored-by: Marko <[email protected]>
jiujiteiro pushed a commit to realiotech/cosmos-sdk that referenced this pull request Mar 7, 2023
@robert-zaremba @yihuang
@julienrbrt @elias-orijtech @tac0turtle @jiujiteiro
build(deps): bump btcd in v0.46 (cosmos#14846)
ab182a9 
Co-authored-by: yihuang <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Elias Naur <[email protected]>
Co-authored-by: Marko <[email protected]>
@Michael-Ixo Michael-Ixo mentioned this pull request Mar 15, 2023
Closed
@faddat faddat mentioned this pull request Mar 23, 2023
Closed
19 tasks
@faddat faddat mentioned this pull request Dec 11, 2023
Draft
19 tasks
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@mergify @robert-zaremba
@julienrbrt @JeancarloBarrios
build(deps): bump btcd in v0.45 (backport cosmos#14846) (cosmos#15127)
ef74491 
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@robert-zaremba @yihuang
@julienrbrt @elias-orijtech @tac0turtle @JeancarloBarrios
build(deps): bump btcd in v0.46 (cosmos#14846)
4236f85 
Co-authored-by: yihuang <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Elias Naur <[email protected]>
Co-authored-by: Marko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testinginprod testinginprod testinginprod approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update btcd: btcd mishandles witness size checking
5 participants
@robert-zaremba @yihuang @julienrbrt @testinginprod @elias-orijtech