Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename to CometBFT #14914

Merged
merged 22 commits into from
Feb 6, 2023
Merged

refactor: rename to CometBFT #14914

merged 22 commits into from
Feb 6, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Feb 5, 2023

Description

ref: #14870, #14897

  • Rename imports to CometBFT
  • Remove replaces when possible
  • Partially update mention of Tendermint in touched files

Note, this does not rename or alias any endpoints yet, nor APIs. A 4th and last PR will do that.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:CLI C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:Rosetta Issues and PR related to Rosetta C:x/circuit C:x/evidence C:x/feegrant C:x/upgrade labels Feb 5, 2023
@julienrbrt julienrbrt marked this pull request as ready for review February 5, 2023 23:26
@julienrbrt julienrbrt requested review from tac0turtle and a team as code owners February 5, 2023 23:26
client/config/toml.go Outdated Show resolved Hide resolved
client/rpc/validators.go Outdated Show resolved Hide resolved
server/cmt_cmds.go Outdated Show resolved Hide resolved
server/util.go Outdated Show resolved Hide resolved
simapp/go.mod Outdated Show resolved Hide resolved
tools/rosetta/converter_test.go Show resolved Hide resolved
x/staking/genesis.go Show resolved Hide resolved
@julienrbrt julienrbrt changed the title refactor!: rename to CometBFT refactor: rename to CometBFT Feb 6, 2023
@julienrbrt julienrbrt enabled auto-merge (squash) February 6, 2023 17:51
@julienrbrt julienrbrt merged commit 80dd55f into main Feb 6, 2023
@julienrbrt julienrbrt deleted the julien/migrate-cometbft-2 branch February 6, 2023 18:11
samricotta pushed a commit that referenced this pull request Feb 7, 2023
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants