Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename commands to match consensus engine name #14956

Merged
merged 11 commits into from
Feb 8, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Feb 8, 2023

Description

ref: #14870

  • Rename relevant commands to default to comet. Alias are created to keep backwards compatibility.
  • Rename tmservice -> cmtservice. The gRPC endpoints are (for now) remaining unchanged.
  • Rename some functions from *Tm* to *Cmt* and alias them for backwards compatibility.
  • Functions are under testutil folder are not aliased.

I believe no more renaming is required after this PR. Only docs update.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: would prefer if all uses of cometbft in strings/code would be replaced with CometBFT :)

@github-actions github-actions bot added C:Rosetta Issues and PR related to Rosetta Type: ADR labels Feb 8, 2023
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utack

@julienrbrt julienrbrt changed the title chore: rename commands to match consensus engine name refactor: rename commands to match consensus engine name Feb 8, 2023
@julienrbrt julienrbrt enabled auto-merge (squash) February 8, 2023 18:50
@julienrbrt julienrbrt merged commit c17c3ca into main Feb 8, 2023
@julienrbrt julienrbrt deleted the julien/renaming branch February 8, 2023 20:09
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants