chore: follow-up of #14985 #14987
Closed
chore: follow-up of #14985 #14987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
force-pushed
the
julien/follow-up
branch
from
a4722a4
to
449c4e6
Compare
julienrbrt
commented
Feb 9, 2023
| @@ -33,6 +33,6 @@ cp -r github.com/cosmos/cosmos-sdk/* ./ | |||
| cp -r cosmossdk.io/** ./ | |||
| rm -rf github.com cosmossdk.io | |||
|
|
|||
| go mod tidy | |||
| # go mod tidy # TODO to be uncommented after https://github.com/cosmos/cosmos-sdk/issues/14988 | |||
|
See my comment here: #14985 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up of #14985 (#14985 (comment)) to decrease the id, as we can be breaking (already done in the backported PR).
Follow-up of #14979 that bumps the proto-builder.(#14988)- Note, now the proto-builder is more pedantic and verifies that protos are properly named (
panic: file name testdata.proto does not start with expected testutil/testdata/; please make sure your folder structure matches the proto files fully-qualified names). This has thus to be changed in tests too.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change