Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent unrevoked validators from unrevoking #1511

Merged
merged 9 commits into from
Jul 3, 2018
Merged

Prevent unrevoked validators from unrevoking #1511

merged 9 commits into from
Jul 3, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jul 2, 2018 •
edited
Loading

Closes #1510

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated Gaia/Examples
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)

@cwgoes cwgoes requested a review from ebuchman as a code owner July 2, 2018 23:58
@cwgoes cwgoes requested a review from rigelrozanski July 2, 2018 23:59
rigelrozanski
rigelrozanski previously approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov
Copy link

codecov bot commented Jul 3, 2018 •
edited
Loading

Codecov Report

Merging #1511 into develop will decrease coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1511      +/-   ##
===========================================
- Coverage    64.17%   64.13%   -0.04%     
===========================================
  Files          118      118              
  Lines         6485     6489       +4     
===========================================
  Hits          4162     4162              
- Misses        2072     2075       +3     
- Partials       251      252       +1

@cwgoes cwgoes merged commit 3f438cd into develop Jul 3, 2018
@cwgoes cwgoes deleted the cwgoes/cannot-unrevoke-unless-revoked branch July 3, 2018 05:47
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 9, 2022
Open
@neutron-robot neutron-robot mentioned this pull request Mar 23, 2024
Closed
@neutron-robot neutron-robot mentioned this pull request Apr 16, 2024
Closed
@xavierpraveen xavierpraveen mentioned this pull request Apr 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebuchman ebuchman ebuchman approved these changes

@rigelrozanski rigelrozanski rigelrozanski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwgoes @ebuchman @rigelrozanski