Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): fix staticcheck issues #15140

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Conversation

mark-rushakoff
Copy link
Member

Remove one duplicated import, and prefer to append a slice rather than iterating over each element to be appended.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

Remove one duplicated import, and prefer to append a slice rather than
iterating over each element to be appended.
@mark-rushakoff mark-rushakoff requested a review from a team as a code owner February 23, 2023 19:47
@julienrbrt julienrbrt enabled auto-merge (squash) February 23, 2023 19:52
@julienrbrt julienrbrt merged commit 79b74ff into main Feb 23, 2023
@julienrbrt julienrbrt deleted the chore/mr-staticcheck-core branch February 23, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants