Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(orm): add missing error checks #15141

Merged
merged 1 commit into from
Feb 23, 2023
Merged

chore(orm): add missing error checks #15141

merged 1 commit into from
Feb 23, 2023

Conversation

mark-rushakoff
Copy link
Member

There were several errors that were unchecked, all but one in test code. Discovered with staticcheck.

Author Checklist

I have...

  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@mark-rushakoff
chore(orm): add missing error checks
0defac3 
There were several errors that were unchecked, all but one in test code.
Discovered with staticcheck.
@mark-rushakoff mark-rushakoff requested a review from a team as a code owner February 23, 2023 20:24
@github-actions github-actions bot added the C:orm label Feb 23, 2023
@julienrbrt julienrbrt enabled auto-merge (squash) February 23, 2023 20:39
@julienrbrt julienrbrt merged commit 2b126af into main Feb 23, 2023
@julienrbrt julienrbrt deleted the mr/orm-check-errors branch February 23, 2023 20:45
@faddat faddat mentioned this pull request Mar 28, 2023
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronc aaronc aaronc approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
C:orm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mark-rushakoff @aaronc @tac0turtle @julienrbrt