refactor(log): elide keyval translation to map #15158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The zerolog Fields method accepts a
[]any
in the same format we use in the Logger interface's methods, so translating the slice to a map is unnecessary.Include microbenchmark to prove this difference.
Before omitting getLogFields:
After omitting getLogFields:
Author Checklist
I have...
!
to the type prefix if API or client breaking changeprovided a link to the relevant issue or specificationCHANGELOG.md
updated the relevant documentation or specificationreviewed "Files changed" and left comments if necessaryReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change