-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/tx): extract signers using cosmos.msg.v1.signer #15205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good me. how would this get plugged into the app?
In an app it would need to be used from the ante handlers to get the signers. There is some other work around making GetSigners optional that I intend to address in a follow up PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, few nits
…-deprecate-get-signers
Co-authored-by: Amaury <[email protected]>
Co-authored-by: Amaury <[email protected]>
Tagging |
Description
Ref: #11275
This adds a method for extracting the list of signers from a message based on the
cosmos.msg.v1.signer
protobuf option. It will allow us to make theGetSigners() []sdk.AccAddress
method optional which is an important part of the bech32 global removal. This method will also be used by autocli/hubl in the short term for transaction signing support.This code is more complicated than I had hoped because
cosmos.msg.v1.signer
supports both nested and repeated signer fields so there are more cases to handle. The functions for extracting the signers are cached the first time they are created to avoid constantly iterating through the logic of the 6 different ways nested and repeated fields can be combined.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change