Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/tx): extract signers using cosmos.msg.v1.signer #15205

Merged
merged 11 commits into from
Mar 6, 2023

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Feb 27, 2023

Description

Ref: #11275

This adds a method for extracting the list of signers from a message based on the cosmos.msg.v1.signer protobuf option. It will allow us to make the GetSigners() []sdk.AccAddress method optional which is an important part of the bech32 global removal. This method will also be used by autocli/hubl in the short term for transaction signing support.

This code is more complicated than I had hoped because cosmos.msg.v1.signer supports both nested and repeated signer fields so there are more cases to handle. The functions for extracting the signers are cached the first time they are created to avoid constantly iterating through the logic of the 6 different ways nested and repeated fields can be combined.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc closed this Feb 27, 2023
@aaronc aaronc reopened this Feb 27, 2023
@aaronc aaronc changed the title feat(x/tx): support cosmos.msg.v1.signer feat(x/tx): extract signers using cosmos.msg.v1.signer Feb 27, 2023
@aaronc aaronc marked this pull request as ready for review February 27, 2023 20:26
@aaronc aaronc requested a review from a team as a code owner February 27, 2023 20:26
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good me. how would this get plugged into the app?

@aaronc
Copy link
Member Author

aaronc commented Mar 2, 2023

it looks good me. how would this get plugged into the app?

In an app it would need to be used from the ante handlers to get the signers. There is some other work around making GetSigners optional that I intend to address in a follow up PR

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few nits

x/tx/internal/testpb/signers.proto Outdated Show resolved Hide resolved
x/tx/signing/get_signers.go Outdated Show resolved Hide resolved
x/tx/internal/testpb/signers.proto Show resolved Hide resolved
@aaronc aaronc merged commit 1f40d9d into main Mar 6, 2023
@aaronc aaronc deleted the aaronc/11275-deprecate-get-signers branch March 6, 2023 16:12
@aaronc
Copy link
Member Author

aaronc commented Mar 6, 2023

Tagging x/tx/v0.2.1 with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants