refactor(log): restore customized nop logger #15257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And clean up a couple benchmarks, to move unrelated allocations out of the hot loop. The specialized nop logger runs about 3x faster than the zerolog wrapper around a zerolog.Nop instance. Since the nop logger is part of the exported API, and since the implementation is very simple, we should continue to offer the faster version.
mark-rushakoff
commented
Mar 3, 2023
| @@ -62,7 +62,7 @@ func NewLoggerWithKV(key, value string) Logger { | |||
| return zeroLogWrapper{&logger} | |||
| } | |||
|
|
|||
| // NewCustomLogger returns a new logger with the given zerolog logger | |||
| // NewCustomLogger returns a new logger with the given zerolog logger. | |||
There was a problem hiding this comment.
@julienrbrt godoc should be full, punctuated sentences.
When they are rendered on pkg.go.dev without punctuation, it looks sloppy, and it's not always clear if they are finished sentences.
There was a problem hiding this comment.
Sure thing! I'll watch out, it does look sloppy without indeed 👍🏾
There was a problem hiding this comment.
this is good to know, i bet there are many other areas we do this
tac0turtle
approved these changes
Mar 3, 2023
julienrbrt
approved these changes
Mar 3, 2023
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
And clean up a couple benchmarks, to move unrelated allocations out of the hot loop.
The specialized nop logger runs about 3x faster than the zerolog wrapper around a zerolog.Nop instance.
Since the nop logger is part of the exported API, and since the implementation is very simple, we should continue to offer the faster version.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeprovided a link to the relevant issue or specificationfollowed the guidelines for building modulesadded a changelog entry toCHANGELOG.mdincluded comments for documenting Go codeupdated the relevant documentation or specificationReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change