Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(x/bank): 👉🥺👈 (reduce logging verbosity) #15266

Merged
merged 1 commit into from
Mar 5, 2023
Merged

perf(x/bank): 👉🥺👈 (reduce logging verbosity) #15266

merged 1 commit into from
Mar 5, 2023

Conversation

itsdevbear
Copy link
Contributor

@itsdevbear itsdevbear commented Mar 5, 2023 •
edited
Loading

@julienrbrt

(can get really spammy when we run our evm's estimate gas)

image

@itsdevbear itsdevbear requested a review from a team as a code owner March 5, 2023 07:57
@itsdevbear itsdevbear changed the title impr(x/bank): 👉🥺👈 (reduce logging verbosity) perf(x/bank): 👉🥺👈 (reduce logging verbosity) Mar 5, 2023
julienrbrt
julienrbrt approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! But maybe I'm missing context on why it was info. So I'd like someone else to ACK this.

tac0turtle
tac0turtle approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont think there was a reason to put it as info.

@tac0turtle tac0turtle merged commit 672b052 into cosmos:main Mar 5, 2023
@tac0turtle
Copy link
Member

@itsdevbear you can also use log filtering to only print the modules you want

@faddat faddat mentioned this pull request Mar 28, 2023
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees
No one assigned
Labels
C:x/bank
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsdevbear @tac0turtle @julienrbrt