-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/tx): Move textual,aminojson to signing #15278
Conversation
@@ -196,6 +196,7 @@ replace ( | |||
cosmossdk.io/x/evidence => ../x/evidence | |||
cosmossdk.io/x/feegrant => ../x/feegrant | |||
cosmossdk.io/x/nft => ../x/nft | |||
cosmossdk.io/x/tx => ../x/tx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the liveness-test is failing because of this change:
go: cosmossdk.io/x/[email protected] (replaced by ./x/tx): reading x/tx/go.mod: open /work/x/tx/go.mod: no such file or directory
any ideas how I can fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe in one of the dockerfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried 60e1d95, let's see
Description
Move
x/tx/{textual,aminojson}
tox/tx/signing/{textual,aminojson}
. This way we can have other things inx/tx
, likex/tx/ante
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change