Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make address codec public #15326

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

tac0turtle
Copy link
Member

Description

ref #13140

make address codec on auth public


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team as a code owner March 9, 2023 13:12
@tac0turtle
Copy link
Member Author

@aaronc for validadator operator and consensus key we would expand the interface or make a specific validator codec for both.

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but where is it supposed to be used? Shouldn't the expected keepers be updated where needed?

@tac0turtle
Copy link
Member Author

tac0turtle commented Mar 9, 2023

lgtm, but where is it supposed to be used? Shouldn't the expected keepers be updated where needed?

it will be passed into other modules, im already using it in circuit, and ill add it to others. I didnt want to do it all at once. Its not used anywhere currently cause everywhere is using the global

@tac0turtle tac0turtle enabled auto-merge (squash) March 9, 2023 13:49
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 9, 2023
@tac0turtle tac0turtle merged commit 112d071 into main Mar 9, 2023
@tac0turtle tac0turtle deleted the marko/make_address_codec_public branch March 9, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants