-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add rfc section #15354
docs: add rfc section #15354
Conversation
@@ -0,0 +1,35 @@ | |||
# RFC {RFC-NUMBER}: {TITLE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
---
sidebar_position: 1
---
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont have this on the adr section, ideally we tell it to not show the template files like we do today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it is fine without it too. It was only required for the README to show properly I think.
Just seen that it does not actually shows in the docs. |
@@ -0,0 +1,38 @@ | |||
--- | |||
sidebar_position: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad @tac0turtle , it was sidebar_position: 1 needed here.
As it is a main section, setting 0 makes it as important as the doc homepage readme :/
Description
This pr adds an RFC section for items that may not need adrs right away or to capture ongoing conversations
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change