Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: hardcode legacy amino endpoint e2e test data #15397

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Mar 14, 2023

Description

Part of #11275. Addresses removed e2e tests from #15299. Basically the test data is hard-coded now rather than being generated from the amino tx builder which will be removed in #15299.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc marked this pull request as ready for review March 14, 2023 19:51
@aaronc aaronc requested a review from a team as a code owner March 14, 2023 19:51
@aaronc aaronc changed the title refactor: hardcode legacy amino endpoint tests refactor: hardcode legacy amino endpoint e2e test data Mar 14, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aaronc aaronc merged commit d50cb1e into main Mar 14, 2023
@aaronc aaronc deleted the aaronc/11275-hardcode-amino-tests branch March 14, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants