Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable sonarcloud on forks #15400

Merged
merged 1 commit into from
Mar 14, 2023
Merged

ci: disable sonarcloud on forks #15400

merged 1 commit into from
Mar 14, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Mar 14, 2023

Description

The issue is sonarcloud does not run on forks from external contributors.
This is what prohibited us to make the job of our components required.
This PR replicates cosmos/interchain-security#768.
I have purposely not added this logic our repo-analysis job as it makes no sense, as this job will never be required.

IMO, afterward, we should make all test-* required (cc @tac0turtle).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner March 14, 2023 18:46
@julienrbrt
Copy link
Member Author

julienrbrt commented Mar 14, 2023

Could an admin make all these tests Tests / Code Coverage / test-* required after this PR?:
image

NOTE: Please wait before making test-store required, as it has been broken in the streaming PR (see #15399 (comment)). We should make it required once it is fixed.

@julienrbrt julienrbrt changed the title chore: disable sonarcloud on forks ci: disable sonarcloud on forks Mar 14, 2023
@tac0turtle tac0turtle merged commit 40c4bf0 into main Mar 14, 2023
@tac0turtle tac0turtle deleted the julien/ci-sonarcloud branch March 14, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants