fix: Makefile rocksdb

[robert-zaremba]

Description

rocksdb_build is a wrong build tag name. Should be rocksdb

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[alexanderbez]

I ran the following:

$ CGO_CFLAGS="-I/opt/homebrew/Cellar/rocksdb/7.10.2/include" CGO_LDFLAGS="-L/opt/homebrew/Cellar/rocksdb/7.10.2 -lrocksdb -lstdc++ -lm -lz -lbz2 -lsnappy -llz4 -lzstd" go get github.com/tecbot/gorocksdb

$ BUILD_TAGS=rocksdb make build
cd /Users/aleksbez/code/cosmos/cosmos-sdk/simapp && go build -mod=readonly -tags "netgo ledger rocksdb" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=sim -X github.com/cosmos/cosmos-sdk/version.AppName=simd -X github.com/cosmos/cosmos-sdk/version.Version=0.46.0-beta2-1655-gdb5c44e455 -X github.com/cosmos/cosmos-sdk/version.Commit=db5c44e455e41cad2b9c51bceaabf0ca2213b607 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger" -X github.com/cometbft/cometbft/version.TMCoreSemVer=v0.37.0 -w -s' -trimpath -o /Users/aleksbez/code/cosmos/cosmos-sdk/build/ ./...
# github.com/linxGnu/grocksdb
../../../../go/pkg/mod/github.com/linx!gnu/[email protected]/array.go:4:11: fatal error: 'rocksdb/c.h' file not found
 #include "rocksdb/c.h"
          ^~~~~~~~~~~~~
1 error generated.
# github.com/tecbot/gorocksdb
../../../../go/pkg/mod/github.com/tecbot/[email protected]/array.go:4:11: fatal error: 'rocksdb/c.h' file not found
 #include "rocksdb/c.h"
          ^~~~~~~~~~~~~
1 error generated.
make: *** [build] Error 1

[yihuang]

I ran the following:

$ CGO_CFLAGS="-I/opt/homebrew/Cellar/rocksdb/7.10.2/include" CGO_LDFLAGS="-L/opt/homebrew/Cellar/rocksdb/7.10.2 -lrocksdb -lstdc++ -lm -lz -lbz2 -lsnappy -llz4 -lzstd" go get github.com/tecbot/gorocksdb

$ BUILD_TAGS=rocksdb make build

cd /Users/aleksbez/code/cosmos/cosmos-sdk/simapp && go build -mod=readonly -tags "netgo ledger rocksdb" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=sim -X github.com/cosmos/cosmos-sdk/version.AppName=simd -X github.com/cosmos/cosmos-sdk/version.Version=0.46.0-beta2-1655-gdb5c44e455 -X github.com/cosmos/cosmos-sdk/version.Commit=db5c44e455e41cad2b9c51bceaabf0ca2213b607 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger" -X github.com/cometbft/cometbft/version.TMCoreSemVer=v0.37.0 -w -s' -trimpath -o /Users/aleksbez/code/cosmos/cosmos-sdk/build/ ./...

# github.com/linxGnu/grocksdb

../../../../go/pkg/mod/github.com/linx!gnu/[email protected]/array.go:4:11: fatal error: 'rocksdb/c.h' file not found

 #include "rocksdb/c.h"

          ^~~~~~~~~~~~~

1 error generated.

# github.com/tecbot/gorocksdb

../../../../go/pkg/mod/github.com/tecbot/[email protected]/array.go:4:11: fatal error: 'rocksdb/c.h' file not found

 #include "rocksdb/c.h"

          ^~~~~~~~~~~~~

1 error generated.

make: *** [build] Error 1

You need to prepare rocksdb c lib manually

[alexanderbez]

@yihuang what does that mean?

[yihuang]

@yihuang what does that mean?

You need to manually install the rocksdb library or compile by yourself, and put the header and library files in the path that can be found by c compilers, or set CGO_CFLAGS and CGO_LDFLAGS for the c compilers to find them.
In our case, we use nix to manage the building process, which is an awesome tool at managing c lib dependencies (https://github.com/crypto-org-chain/cronos/blob/main/default.nix#L23), it can do cross-compiling, static-linking with the c dependencies right.

[robert-zaremba]

You need to prepare rocksdb c lib manually

Also, I don't think it works with the latest rocksdb version.

[robert-zaremba]

I think we should not enable ROCKSDB by default: https://github.com/cosmos/cosmos-sdk/pull/15422/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R16

1. It requires CGO and right version of rocksdb lib
2. I prefer the original version (with ENABLE_ROCKSDB): it's more explicit

[alexanderbez]

@yihuang the FB authors themselves state you should install it via brew for macOS.

https://github.com/facebook/rocksdb/blob/main/INSTALL.md#supported-platforms

Why should I install it manually by compiling from source then?

[yihuang]

@yihuang the FB authors themselves state you should install it via brew for macOS.

https://github.com/facebook/rocksdb/blob/main/INSTALL.md#supported-platforms

Why should I install it manually by compiling from source then?

Sometimes with manually compiling you can pick whatever version of source code you want. But I almost always use nix for both Mac and Linux platforms, which is more automated, and flexible to control the build process.

[alexanderbez]

Ok, I'll try compiling from source on a lower version. Which version do you use/recommend?

[yihuang]

Ok, I'll try compiling from source on a lower version. Which version do you use/recommend?

we were using v6.29.5 when using gorocksdb.

[alexanderbez]

Ran make static_lib on that version and still can't get the SDK to build. Not sure how to link the libs or test this...

[yihuang]

Ran make static_lib on that version and still can't get the SDK to build. Not sure how to link the libs or test this...

I guess you just need sth like this:

$ export CGO_CFLAGS="-I/path/to/rocksdb/include"
$ export CGO_LDFLAGS="-L/path/to/rocksdb/lib -lrocksdb -pthread -lstdc++ -ldl -lzstd -lsnappy -llz4 -lbz2 -lz"

[yihuang]

So , for this PR, I propose:

• don't add RocksDB to default build tags (remove change: https://github.com/cosmos/cosmos-sdk/pull/15422/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R16)

And after that we can merge it. Any objections / comment?

It's already the case I think, you need to put rocksdb in COSMOS_BUILD_OPTIONS to enable it

[alexanderbez]

I dont feel comfortable merging any RocksDB related PRs until we have sufficient documentation for using it. I still have not successfully been able to build RocksDB with a Cosmos SDK version...

[robert-zaremba]

It's already the case I think, you need to put rocksdb in COSMOS_BUILD_OPTIONS to enable it

Yes, because it was added temporarily here, so I removed it (hence the comment).

I dont feel comfortable merging any RocksDB related PRs until we have sufficient documentation

Yes, there is another issue to solve that problem. This PR only cleans up the Makefile, which has outdated / wrong variables.

[Staking7pc]

I am trying to build some binaries with rocksdb and facing the same issues that are descried here . Is there a specifi version of rocksdb or /root/go/pkg/mod/github.com/cosmos/[email protected] to be used when building ?

[alexanderbez]

If you figure it out, please let me know. We still don't have a doc on this. @facundomedica @yihuang

[yihuang]

I am trying to build some binaries with rocksdb and facing the same issues that are descried here . Is there a specifi version of rocksdb or /root/go/pkg/mod/github.com/cosmos/[email protected] to be used when building ?

Yes, I only built gorocksdb with rocksdb v6.8.x, to build with recent version, we'll need grocksdb, there's PR for migrating to that.

[Staking7pc]

I am trying to build some binaries with rocksdb and facing the same issues that are descried here . Is there a specifi version of rocksdb or /root/go/pkg/mod/github.com/cosmos/[email protected] to be used when building ?

Yes, I only built gorocksdb with rocksdb v6.8.x, to build with recent version, we'll need grocksdb, there's PR for migrating to that.

I tried wiih v6.8.1 as well but having below error .

/root/go/pkg/mod/github.com/cosmos/[email protected]/transactiondb.go:255:17: could not determine kind of name for C.rocksdb_optimistictransactiondb_checkpoint_object_create /root/go/pkg/mod/github.com/cosmos/[email protected]/transactiondb.go:208:12: could not determine kind of name for C.rocksdb_optimistictransactiondb_property_value /root/go/pkg/mod/github.com/cosmos/[email protected]/transactiondb.go:236:2: could not determine kind of name for C.rocksdb_optimistictransactiondb_write /root/go/pkg/mod/github.com/cosmos/[email protected]/transactiondb.go:59:12: could not determine kind of name for C.rocksdb_transactiondb_property_value make: *** [Makefile:42: install] Error 2

The main intention I wanna try rocksdb is to see if it reduces the IO . Its mentioned here in #10987

[yihuang]

I am trying to build some binaries with rocksdb and facing the same issues that are descried here . Is there a specifi version of rocksdb or /root/go/pkg/mod/github.com/cosmos/[email protected] to be used when building ?

Yes, I only built gorocksdb with rocksdb v6.8.x, to build with recent version, we'll need grocksdb, there's PR for migrating to that.

I tried wiih v6.8.1 as well but having below error .

`/root/go/pkg/mod/github.com/cosmos/[email protected]/transactiondb.go:255:17: could not determine kind of name for C.rocksdb_optimistictransactiondb_checkpoint_object_create

/root/go/pkg/mod/github.com/cosmos/[email protected]/transactiondb.go:208:12: could not determine kind of name for C.rocksdb_optimistictransactiondb_property_value

/root/go/pkg/mod/github.com/cosmos/[email protected]/transactiondb.go:236:2: could not determine kind of name for C.rocksdb_optimistictransactiondb_write

/root/go/pkg/mod/github.com/cosmos/[email protected]/transactiondb.go:59:12: could not determine kind of name for C.rocksdb_transactiondb_property_value

make: *** [Makefile:42: install] Error 2`

The main intention I wanna try rocksdb is to see if it reduces the IO . Its mentioned here in #10987

Sorry, we were using v6.29.5, can you try that?

[Staking7pc]

I am trying to build some binaries with rocksdb and facing the same issues that are descried here . Is there a specifi version of rocksdb or /root/go/pkg/mod/github.com/cosmos/[email protected] to be used when building ?

Yes, I only built gorocksdb with rocksdb v6.8.x, to build with recent version, we'll need grocksdb, there's PR for migrating to that.

I tried wiih v6.8.1 as well but having below error .
/root/go/pkg/mod/github.com/cosmos/[email protected]/transactiondb.go:255:17: could not determine kind of name for C.rocksdb_optimistictransactiondb_checkpoint_object_create /root/go/pkg/mod/github.com/cosmos/[email protected]/transactiondb.go:208:12: could not determine kind of name for C.rocksdb_optimistictransactiondb_property_value /root/go/pkg/mod/github.com/cosmos/[email protected]/transactiondb.go:236:2: could not determine kind of name for C.rocksdb_optimistictransactiondb_write /root/go/pkg/mod/github.com/cosmos/[email protected]/transactiondb.go:59:12: could not determine kind of name for C.rocksdb_transactiondb_property_value make: *** [Makefile:42: install] Error 2
The main intention I wanna try rocksdb is to see if it reduces the IO . Its mentioned here in #10987

Sorry, we were using v6.29.5, can you try that?

Yes I can build the binary with v6.29.5 and start synching with rocksdb as database . Thanks