Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bank): update InputOutputCoins arguments #15477

Merged
merged 6 commits into from
Mar 20, 2023
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Mar 20, 2023

Description

When re-looking at #12610

Noticed the very valid argument of: realiotech#24.
#12670 indeed reverted too much.
This clean-up the API to make it more understandable what is the behavior of InputOutputCoins.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner March 20, 2023 16:23
@julienrbrt julienrbrt marked this pull request as draft March 20, 2023 16:25
@julienrbrt julienrbrt marked this pull request as ready for review March 20, 2023 16:58
@github-actions github-actions bot added the C:CLI label Mar 20, 2023
@julienrbrt julienrbrt enabled auto-merge (squash) March 20, 2023 17:08
@julienrbrt julienrbrt merged commit 6acd5cc into main Mar 20, 2023
@julienrbrt julienrbrt deleted the julien/clean-up branch March 20, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants