-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use app config configurator for removing boilerplate #15499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:x/auth
C:x/authz
C:x/distribution
distribution module related
C:x/evidence
C:x/feegrant
C:x/group
C:x/mint
C:x/nft
C:x/params
C:x/slashing
C:x/staking
labels
Mar 21, 2023
@julienrbrt your pull request is missing a changelog! |
Hey bot! My PR is in draft :/ |
github-actions
bot
added
C:CLI
C:Confix
Issues and PR related to Confix
C:Cosmovisor
Issues and PR related to Cosmovisor
C:Hubl
Tool: Hubl
C:orm
C:Rosetta
Issues and PR related to Rosetta
C:Store
C:x/circuit
C:x/tx
C:x/upgrade
labels
Mar 21, 2023
julienrbrt
force-pushed
the
julien/app-config-simplify
branch
from
March 21, 2023 16:29
07e683b
to
c34371e
Compare
github-actions
bot
removed
C:Confix
Issues and PR related to Confix
C:CLI
C:x/upgrade
C:orm
labels
Mar 21, 2023
github-actions
bot
removed
C:x/tx
C:Rosetta
Issues and PR related to Rosetta
C:x/circuit
C:Cosmovisor
Issues and PR related to Cosmovisor
C:Store
C:Hubl
Tool: Hubl
labels
Mar 21, 2023
github-actions
bot
added
C:CLI
C:Confix
Issues and PR related to Confix
C:Cosmovisor
Issues and PR related to Cosmovisor
C:Hubl
Tool: Hubl
C:Rosetta
Issues and PR related to Rosetta
C:x/circuit
C:x/upgrade
labels
Mar 21, 2023
tac0turtle
approved these changes
Mar 22, 2023
19 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:CLI
C:Confix
Issues and PR related to Confix
C:Cosmovisor
Issues and PR related to Cosmovisor
C:Hubl
Tool: Hubl
C:Rosetta
Issues and PR related to Rosetta
C:x/auth
C:x/authz
C:x/circuit
C:x/distribution
distribution module related
C:x/evidence
C:x/feegrant
C:x/group
C:x/mint
C:x/nft
C:x/params
C:x/slashing
C:x/staking
C:x/upgrade
Type: CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small refactors of app configs to use the configurator, as it is more readable.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change