Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip rpc tests till comet fix issue with data race #15570

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Mar 28, 2023

Description

to be reverted once cometbft/cometbft#487 is solved. the amount of failures is becoming a hindering aspect on the sdk teams development

tracking issue for when we revert #15571


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Mar 28, 2023
@tac0turtle tac0turtle marked this pull request as ready for review March 28, 2023 13:34
@tac0turtle tac0turtle requested a review from a team as a code owner March 28, 2023 13:34
@tac0turtle tac0turtle enabled auto-merge (squash) March 28, 2023 13:59
@tac0turtle tac0turtle merged commit f15cbac into main Mar 28, 2023
@tac0turtle tac0turtle deleted the marko/comet_rpc branch March 28, 2023 14:20
@tac0turtle tac0turtle mentioned this pull request Apr 12, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants