Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Close method for resource cleanup in graceful shutdown (backport #16193) #16204

Merged
merged 3 commits into from
May 19, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 18, 2023

This is an automatic backport of pull request #16193 done by Mergify.
Cherry-pick of 09ca393 has failed:

On branch mergify/bp/release/v0.47.x/pr-16193
Your branch is up to date with 'origin/release/v0.47.x'.

You are currently cherry-picking commit 09ca393a1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   baseapp/baseapp.go
	modified:   server/types/app.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   server/start.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

)

Co-authored-by: Aleksandr Bezobchuk <[email protected]>
(cherry picked from commit 09ca393)

# Conflicts:
#	CHANGELOG.md
#	server/start.go
@mergify mergify bot requested a review from a team as a code owner May 18, 2023 07:14
@mergify mergify bot added the conflicts label May 18, 2023
@yihuang yihuang removed the conflicts label May 18, 2023
server/start.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt enabled auto-merge (squash) May 19, 2023 09:38
@julienrbrt julienrbrt merged commit 273386f into release/v0.47.x May 19, 2023
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.47.x/pr-16193 branch May 19, 2023 09:56
roy-dydx pushed a commit to dydxprotocol/cosmos-sdk that referenced this pull request Jul 11, 2023
kakysha pushed a commit to InjectiveLabs/cosmos-sdk that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants