fix(cli): improve prune command ux
#16856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added
backport/v0.47.x
This comment has been minimized.
This comment has been minimized.
julienrbrt
added
the
backport/0.46.x
alexanderbez
approved these changes
Jul 6, 2023
| cmd := &cobra.Command{ | ||
| Use: "prune", | ||
| Use: "prune [pruning-method]", | ||
| Short: "Prune app history states by keeping the recent heights and deleting old heights", | ||
| Long: `Prune app history states by keeping the recent heights and deleting old heights. |
There was a problem hiding this comment.
Can we confirm the output of this displays nicely and is formatted correctly?
There was a problem hiding this comment.
There is a spacing issue, let me fix it.
mergify bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit 317fb0b) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit 317fb0b) # Conflicts: # CHANGELOG.md # client/pruning/main.go # simapp/simd/cmd/root.go # simapp/simd/cmd/root_v2.go
mergify bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit 317fb0b) # Conflicts: # CHANGELOG.md # client/pruning/main.go # simapp/simd/cmd/root.go # simapp/simd/cmd/root_v2.go
This was referenced Jul 7, 2023
julienrbrt
added a commit
that referenced
this pull request
Jul 7, 2023
Co-authored-by: Julien Robert <[email protected]>
julienrbrt
added a commit
that referenced
this pull request
Jul 7, 2023
Co-authored-by: Julien Robert <[email protected]>
julienrbrt
added a commit
that referenced
this pull request
Jul 7, 2023
Co-authored-by: Julien Robert <[email protected]>
GAtom22
pushed a commit
to evmos/cosmos-sdk
that referenced
this pull request
Jul 12, 2023
…16876) Co-authored-by: Julien Robert <[email protected]>
GAtom22
pushed a commit
to evmos/cosmos-sdk
that referenced
this pull request
Jul 12, 2023
…16876) Co-authored-by: Julien Robert <[email protected]>
cmwaters
added a commit
to celestiaorg/cosmos-sdk
that referenced
this pull request
Aug 15, 2023
* build(deps): bump cometbft to v0.34.29 (cosmos#16553) * fix(x/auth): ensure nil .BaseAccounts are reported in ModuleAccount.Validate (backport cosmos#16554) (cosmos#16570) Co-authored-by: Emmanuel T Odeke <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: snapshotter's failure is not propogated (backport cosmos#16588) (cosmos#16604) Co-authored-by: yihuang <[email protected]> * feat: add custom max gas for block for sim config (backport cosmos#16656) (cosmos#16731) Co-authored-by: mmsqe <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: accaddr cachefix (backport cosmos#15433) (cosmos#16823) Co-authored-by: KyleMoser <[email protected]> Co-authored-by: HuangYi <[email protected]> * fix(cli): improve `prune` command ux (backport cosmos#16856) (cosmos#16876) Co-authored-by: Julien Robert <[email protected]> * fix: query tx events with `>=` and `<=` operators (cosmos#16994) * docs: change bank multi-send command description (backport cosmos#16950) (cosmos#17019) * chore: prepare v0.46.14 (cosmos#16879) * refactor: add MigrateHandler to allow reuse migrate genesis related function (backport cosmos#17296) (cosmos#17301) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: resolve migration map in MigrateHandler (cosmos#17301) (cosmos#17302) * feat(x/gov): Emit VoterAddr (backport cosmos#17354) (cosmos#17357) Co-authored-by: Devon Bear <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(x/gov): add MsgSubmitProposal SetMsgs method (backport cosmos#17387) (cosmos#17388) Co-authored-by: Julien Robert <[email protected]> --------- Co-authored-by: Julien Robert <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Emmanuel T Odeke <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: mmsqe <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: KyleMoser <[email protected]> Co-authored-by: Rootul P <[email protected]> Co-authored-by: Devon Bear <[email protected]>
19 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16855
Right now, passing the home flag is mandatory otherwise it panics. It isn't a great UX, as every other SDK commands do not require to always pass a flag.
Looking as well now how to make the ux for this command better.
In the backport, I'll do it non-breaking for v0.46 and v0.47.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change