-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gov): Add proposal failed reason #16976
Conversation
Can you fix the failing test and add a changelog under unreleased features? |
|
||
// failed_reason defines the reason why the proposal failed | ||
// | ||
// Since: cosmos-sdk 0.50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tac0turtle is this something we get into 0.50 or wait until 0.51?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changeset is pretty trivial. Would be a nice win to get this in
…smos-sdk into gov-add-reasonfailed
Done! It turns out the failing test was just a misaligned line. Hope the changelog is also ok. |
|
||
// failed_reason defines the reason why the proposal failed | ||
// | ||
// Since: cosmos-sdk 0.50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changeset is pretty trivial. Would be a nice win to get this in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thank you for tackling this.
Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit 80e3c7a)
Co-authored-by: Ahmet Ömer Kayabaşı <[email protected]>
Description
Add "failed_reason" field to gov proposal.
Closes: #16877
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change