Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(abci): Pass context to TxSelector #17932

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

itsdevbear
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@itsdevbear itsdevbear requested a review from a team as a code owner September 30, 2023 19:03
@tac0turtle tac0turtle added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Sep 30, 2023
@itsdevbear
Copy link
Contributor Author

wait actually are we down to pass the req ptr as well?

@julienrbrt
Copy link
Member

wait actually are we down to pass the req ptr as well?

Sounds dangerous to be able to change the request within the txSelector imho.

@itsdevbear
Copy link
Contributor Author

For context what i'm trying to do is build an Ethereum header in the TxSelector, so knowing the proposer is needed.

@julienrbrt julienrbrt added this pull request to the merge queue Oct 2, 2023
Merged via the queue into cosmos:main with commit a68a02a Oct 2, 2023
40 of 45 checks passed
mergify bot pushed a commit that referenced this pull request Oct 2, 2023
julienrbrt pushed a commit that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants